GitLab

The OS Settings' settings-menu element acts as a table of contents containing
names of all the sections. When the user clicks one of these items [1], the
screen automatically scrolls down to that section's header [2]. However, the
DOM focus (and therefore the a11y focuse) remain on the menu item instead of
passing to the section itself [3]. This behavior is both inconvenient and
counter-intuitive because users expect a navigating to an element to
correspond to focusing on it. In particular, if the user is unable to see the
screen, this transition is especially hard to follow.

This CL corrects this behavior in OS Setting [4] as demonstrated in [5].

Update: See [6] for a video of Patchset 3 (i.e. with the outline removed).

[1] https://screenshot.googleplex.com/TrP1LgfE5YD
[2] https://screenshot.googleplex.com/SLSwfWzmkOH
[3] https://screenshot.googleplex.com/LENuPfqdEMC
[4] Note that this change does not affect browser settings. The fix can be
easily extended to browser settings by adding the line added here to
os_settings_main's onShowingSection_() method to settings_main's
onShowingSection_() method.
[5] https://drive.google.com/file/d/1c9yBaLBUnVwXyV5PHZnOoCkLCt2uRcZK/view?usp=sharing
[6] https://drive.google.com/file/d/1jx2sOnJFqfLp5BffhfiUq3Y65hz5kG2I/view?usp=sharing

Bug: 987406
Change-Id: I9794d706dc57fc42ce9202c709e280a32888b8a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874816
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710174}