GitLab

Changes between reland 1 and reland 2:

1.) Added lazy load ensure load to relevant privacy subpage tests.

> Changes between original submission and reland:

> 1.) Privacy-page subpages are now in lazy_load.html
> 2.) Fixed bug that erroneously showed "privacy" in the settings menu of "Guest" mode settings.
> 3.) Fixed bug where going to chrome://settings/clearBrowsingData didn't work unless the advanced section was expanded when the flag for this change was disabled.
> 4.) Reordered a few settings rows to match the most current mocks.

>> Revert "Friendly Privacy Setting Initial Redesign"

>> This reverts commit 544412a4.

>> Reason for revert: Performance and functional regressions
>> https://bugs.chromium.org/p/chromium/issues/detail?id=1024034#c5

>>> Original change's description:
>>> Friendly Privacy Setting Initial Redesign

> >>> This CL does 3 things:
> >>> 1) The order of rows in the privacy page is affected, regardless of the value of the "privacySettingsRedesignEnabled" flag.
> >>> 2) The privacy-page is moved to the "basic", only when the "privacySettingsRedesignEnabled" flag is on.
> >>> 3) A "more" expansion button is introduced in the privacy-page only when the "privacySettingsRedesignEnabled" flag.

>>> Bug: 1014143
>>> Change-Id: I678e81aa3b67acd2ae41eeda355cd3b32a5b4088
>>> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872094
>>> Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
>>> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
>>> Cr-Commit-Position: refs/heads/master@{#714287}

Change-Id: I127cdd31a404f4c7df0d75650e762536fcefd053
Bug: 1031520
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950954
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722657}