• Timothy Gu's avatar
    Fire XHR abort event from a task · 177405e7
    Timothy Gu authored
    A test for this new behavior is included as
    external/wpt/xhr/abort-after-stop.htm.
    
    This also means that XHR abort and readystatechange events from
    navigation is no longer fired. Because of that,
    external/wpt/xhr/open-url-multi-window-4.htm now times out rather than
    fails on an assertion, aligning with Firefox. A TestExpectations entry
    has been added with a bug that tracks fixing this test in spec or
    upstream in WPT. A few other test expectations were updated as well to
    account for this.
    
    http/tests/navigation/reentrant-xhr-onabort-crash-during-commit.html no
    longer works as intended, as abort event is no longer fired
    synchronously (and thus does not expose the same crash surface). It is
    replaced with an EventSource-based test that functions the same way as
    XHR before this CL. Note, currently EventSource's error event suffers
    from the same problem as XHR's abort event, and the class might undergo
    the same change as this in the future. We will look into an alternative
    for this test when that change is done.
    
    Bug: 879620, 881180
    Change-Id: I5a91047086d06347794656f92511a53c22401b5e
    Reviewed-on: https://chromium-review.googlesource.com/1208672Reviewed-by: default avatarPhilip Jägenstedt <foolip@chromium.org>
    Reviewed-by: default avatarYutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Timothy Gu <timothygu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#589634}
    177405e7
open-after-stop.window.js 1.39 KB