GitLab

The chrome.identity.onSigninChanged extension API event is defined
as follows:

"Fired when signin state changes for an account on the user's profile."
(https://developer.chrome.com/apps/identity#event-onSignInChanged)

The current browser-side implementation uses gaia::AccountTracker,
which ignores events for secondary accounts if there is no primary
account (i.e., syncing account) present. Thus, this browser-side
implementation also fires events for secondary accounts only if there is
a primary account present.

However:

(1) This behavior is not defined in the documented semantics above
(2) In practice, this case has historically never been encountered by
end users, as it has been impossible in desktop Chrome to have a
secondary account without a primary account present.

In this CL, we are removing browsertests that enforce this undocumented
behavior (note that we ourselves added these browsertests merely to
document the existing implementation's behavior before refactoring it).
By removing the requirement that the implementation behave in a specific
way in this case, we will ease the upcoming refactoring significantly.

Note that post-project DICE, it will be possible for this case to be
encountered by end users. In that world, it will actually be more
sensible for events to fire for secondary accounts regardless of
whether or not the user has designated a syncing account. This behavior
is what will occur post the refactoring that will follow this CL.

Bug: 729542
Change-Id: I02c1ffbcbfd732ba17056e939eb6f86ab3b26576
Reviewed-on: https://chromium-review.googlesource.com/966035Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544665}