GitLab

Historically, ClientCertStoreChromeOS lived in //net and depended on the
CrOS NSS profile logic in //crypto. To reduce the dependency on that
mess, https://codereview.chromium.org/663583006 extracted the filtering
logic into a separate ClientCertFilterChromeOS in //chrome, indirected
via a CertFilter interface.

This was done in preparation for
https://codereview.chromium.org/419013003/, which was since abandoned
(although the initialization still needs cleanup, per
https://crbug.com/1018972). It also left the ClientCertFilterChromeOS
logic entirely untested.

Since then, ClientCertStoreChromeOS has moved into //chrome, so we no
longer need the indirection. Fold it back in and test the user profile
logic directly to restore ClientCertFilterChromeOS's test coverage. This
is done preparation for work on https://crbug.com/1011576, which will
affect this code somewhat.

This moves the pre-NSS-3.30 workaround for importing ECDSA keys from
ssl_platform_key_nss_unittest.cc to cert_test_util_nss.cc so it works
for all callers of ImportSensitiveKeyFromFile.

Bug: 1011576
Change-Id: I26ae5d610b8b7e443c18ca1314d16129a8f52350
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888312
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711301}