• rbpotter's avatar
    Print Preview: Set settings.pages to the n-up pages · 36545d44
    rbpotter authored
    settings.pages is used outside of pages_settings.js for 3 reasons:
    (1) To send page numbers to the PDF plugin
    (2) To set the page count in the print header
    (3) To set the page count in the print ticket
    
    During the development of the N-up printing feature it has become
    clear that the n-up pages need to be used in place of the original
    document page indices in all 3 of these locations, so we should set
    settings.pages to the n-up values.
    
    Note that the print preview ticket still needs to use the page
    indices for the original document, in order to know what pages
    should be included in the preview. However, since PrintPreviewHandler
    expects this setting to be in ranges format, the print preview
    ticket uses settings.ranges, which this CL keeps the same as before
    (i.e. using the original document's page numbers).
    
    Bug: None
    Change-Id: Ieaad8d75e5125c0dac185f407c665b336aaf4334
    Reviewed-on: https://chromium-review.googlesource.com/1174704Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
    Reviewed-by: default avatarScott Chen <scottchen@chromium.org>
    Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#584633}
    36545d44
header_test.js 5.46 KB