GitLab

Make the smart card PIN errors being dispatched to the a11y subsystem
more reliably, by directly associating the error text with the PIN input
field.

This allows to support the scenario when the PIN keyboard is hidden
during PIN verification animation and shown back. Before this CL, the
error alert would be lost in such scenario, since it's followed by the
focus switch events.

Also do a small cleanup by removing the "aria-invalid" attribute from
the <pin-keyboard> element, since it doesn't seem to be recognized by
the a11y screen reader, meanwhile the actual useful attribute is already
set thanks to the dataflow "<pin-keyboard has-error>" => "<cr-input
invalid>" => "<input aria-invalid>".

Bug: 1001612, 1016839
Change-Id: Ib7baff4bf5d172ada92fbb035455894b1baff5ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031106
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737471}