• Lan Wei's avatar
    Revert "OOBE - Improve reset screen confirmation dialog" · 66300985
    Lan Wei authored
    This reverts commit 8411cc66.
    
    Reason for revert: <INSERT REASONING HERE>
    ResetFirstAfterBootTest.ViewsLogic fails on Builder linux-chromeos-chrome
    https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome
    
    Original change's description:
    > OOBE - Improve reset screen confirmation dialog
    > 
    > - Replace the dialog on the reset screen with the oobe-help-dialog
    >   that complies with UX specs and reuses available code.
    > 
    > - Refactor the confirmation dialog logic so that it lives in the
    >   main element 'oobe-reset'.
    > 
    > - Remove the intermediate oobe_reset_screen by using LoginScreenBehavior
    > 
    > - Add a waiter to test::OobeJS for waiting upon the presence of an
    >   attribute. Such as waiting on the 'open' attribute of dialogs.
    > 
    > - Add constants and modifications to the browser tests of the reset
    >   screen.
    > 
    > Fixed: 933310
    > Change-Id: I54001745326b60ab5a0a19519923c54dffa5baec
    > Bug: 933310
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041474
    > Commit-Queue: Renato Silva <rrsilva@google.com>
    > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
    > Auto-Submit: Renato Silva <rrsilva@google.com>
    > Cr-Commit-Position: refs/heads/master@{#744288}
    
    TBR=antrim@chromium.org,rsorokin@chromium.org,rrsilva@google.com
    
    Change-Id: I5a98467310e478ccd20c0cb3c9b92461229c5b3f
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 933310
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072916Reviewed-by: default avatarLan Wei <lanwei@chromium.org>
    Commit-Queue: Lan Wei <lanwei@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#744419}
    66300985
oobe_screen_reset.js 7.12 KB