GitLab

This CL allows users to use the Feedback keyboard shortcut to launch the
Feedback UI and send Feedback. This also fixes an issue with the current
implementation of login feedback, where if we try to send feedback after
we have launched the app before and restarted Chrome, the UI would not
launch.

This is because on the first run, the background host is always created
just to get the types of events the app can handle. Once this is done,
we save this information in the extension registry and only load the
app once the event is actually dispatched. Since the existing code
was instead waiting for the host to load, it would never send the
event and wait forever.

Instead we're not checking if the extension has been added to the
registry. If it has, we can safely dispatch the event. If not, we instead
wait for the extension to load and then send feedback.

I've tested that this works now both for the first run and subsequent runs
of the app. The existing browser test should still be applicable since the
CL just changed the entry point for login feedback; did not add any
additional functionality.

R=rdevlin.cronin@chromium.org, xiyuan@chromium.org

Bug: 809715
Change-Id: Ib26cb879b15334c010bfed539bc83384c09d2a01
Reviewed-on: https://chromium-review.googlesource.com/953372
Commit-Queue: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541958}