GitLab

This is a reland of 63c4f9f5

The problem with the reverted CL is that a binding file needs updating.
third_party/blink/renderer/bindings/generated_in_core.gni should be
manually updated to point to the newly generated binding classes.
The reason CQ and my local didn't catch this is because the old
generated files v8_shadow_root_slotting(.h|.cc) still exists. But a
clean build will fail.

This CL is the reverted CL plus updates to generated_in_core.gni. See
patch 1 for the failed case. Patch 2 has the update and failed try job
passes.

Original change's description:
> Adds slotAssignmentMode to the shadow root bindings.
>
> Prior to this CL, the previous implementation of imperative slot API uses
> 'slotting' as an optional parameter for Element.attachShadow(). However,
> based on the feedback by JanMiksovsky@ in
> https://github.com/w3c/webcomponents/pull/866, the parameter should be
> changed to 'slotAssignment' to make it align with other members,
> assignNodes(), assignElements(). I agree with this feedback.
>
> This CL updates the following:
> 1. update bindings where the previous 'slotting' was used to
>  'slotAssignment'.
> 2. Updated the enum type of slotAssignment. It should be,
>  SlotAssignmentMode [auto | manual].
> 3. Added attribute 'slotAssignment' to Shadow_Root.idl and updated
>  global-interface-listing-expected.txt.
> 4. Modify existing tests from using slotting to slotAssignment.
> 5. Removed test that'll be covered by
>  external/wpt/shadow-dom/slots-imperative-slot-api.tentative.html.
> https://chromium-review.googlesource.com/c/chromium/src/+/2083742
> I'll update this CL with the correct
>  slots-imperative-slot-api.tentative-expected.txt once that CL lands.
>
> Bug: 869308
> Change-Id: I0fb1a9e11c88d52fc0b0570f3f3e1f5bf834f858
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084376
> Commit-Queue: Yu Han <yuzhehan@chromium.org>
> Reviewed-by: Mason Freed <masonfreed@chromium.org>
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#748116}

Bug: 869308
Change-Id: I26121ca421d707393afc720c1c5918ff36373f29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096784Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749215}