• Noel Gordon's avatar
    [piexwasm] Remove ColorSpace from ImageLoaderRequest · 61e4bfab
    Noel Gordon authored
    ColorSpace is an internal detail of the image loader and should not be
    visible to clients: remove it from ImageLoaderRequest.
    
    The internal use is in ImageRequestTask: add a colorSpace_ member, and
    document that it used for RAW images (PIEX) only. After CL:2432150, it
    was decided that we just use the raw string PIEX color space value, so
    extend that idea and use the raw string in ImageLoaderUtil too (allows
    us to remove ColorSpace). No change in behavior.
    
    Spelling correction: ganna => gamma. Checked the veracity of the color
    space transform adobeRgb to sRgb and it is correct. This code appeared
    before the <canvas> element had color management. The <canvas> element
    supports that feature today in Chrome: add a TODO.
    
    Bug: 1132695
    Change-Id: I12cad9a0aea106ce4a6c6dcbc2a9137bf0224e58
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437530Reviewed-by: default avatarTrent Apted <tapted@chromium.org>
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#811549}
    61e4bfab
image_request_task.js 17.9 KB