GitLab

cr.icon.getFavicon previously took in a URL and used regex to determine
if the URL is a favicon or a site/page URL, but each caller already knows
if the URL is an icon or a page URL.

This is to ultimately be able to use this method for the WebUI tab strip
given a favicon URL and bypass the regex check since favicons out in the
web can technically be gifs, jpgs, data URLs, etc.

This CL also fixes an issue where favicon .ico/.png URLs had params added
at the end and were therefore not detected by the regex.

Bug: 989131
Change-Id: I999ccf7d75e4e2401d54e861c735487c33ee1bdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761327
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688740}