GitLab

SettingsPageBrowsertest added another layer of test classes that was
not used by the SettingsUIBrowserTest and was partially intentionally
overridden in the AboutPageBrowsertest.

Remove this class and move the only 2 shared functions to a new file
that provides them as test_utils, and move other behavior/functions to
AdvancedPageBrowsertest, which is the only test that uses them.

Also re-enabling SettingsUIBrowsertest by changing the browsePreload
to only load settings_ui.html, and by removing the
SettingsPageBrowsertest setup, which may have been causing the
flakiness.

Bug: 1026426, 986985
Change-Id: I8e51cd9f1926bf35b9b12ad15213bd7b816b60a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095864
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749309}