• Reid Kleckner's avatar
    Revert "Fix the issue with 3rd-party DLL blocking and IAttachmentExecute" · 6ab174bd
    Reid Kleckner authored
    This reverts commit ed0a1be1.
    
    Reason for revert: Causes a test failure in official builds:
    https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/91463
    
    Original change's description:
    > Fix the issue with 3rd-party DLL blocking and IAttachmentExecute
    > 
    > Because the IAttachmentExecute interface will invoke registered
    > third-party IOfficeAntiVirus provider, it's possible to put Chrome
    > in a state where all downloads fail if a DLL needed by one of the
    > provider is blocked.
    > 
    > This CL introduces 2 temporary solutions that aims to separately
    > address the issue for enterprise and regular users. The long-term
    > solution is to move the call to the attachment services to a
    > utility process where third-party DLL injection is explicitly
    > allowed.
    > 
    > For enterprise users, simply never enable the blocking feature on
    > domain-joined machines.
    > 
    > For regular users, add a feature (InvokeAttachmentServices) that
    > allows us to no longer invoke the IAttachmentExecute interface and
    > instead use the fallback code path that manually sets the Zone
    > Identifier (Mark of the Web).
    > 
    > The fallback code was a bit outdated because Windows 10 now adds the
    > HostUrl and ReferrerUrl data into the Zone Identifier. This CL adds
    > a new feature that writes this data similarly to how the
    > IAttachmentExecute interface does. This change is also behind a new
    > feature (AugmentedZoneIdentifier).
    > 
    > Finally, the chrome.mediaGalleries API
    > (https://developer.chrome.com/apps/mediaGalleries) was also using
    > the IAttachmentExecute API. A third feature now controls whether
    > the mediaGalleries component uses the same function as the download
    > manager, in order to benefits from the changes described above.
    > 
    > Bug: 870998
    > Change-Id: I50c5d804c469b2499f1e6ec6998e146baaaace7a
    > Reviewed-on: https://chromium-review.googlesource.com/1188864
    > Reviewed-by: Asanka Herath <asanka@chromium.org>
    > Reviewed-by: Lei Zhang <thestig@chromium.org>
    > Reviewed-by: Chris Hamilton <chrisha@chromium.org>
    > Reviewed-by: Min Qin <qinmin@chromium.org>
    > Commit-Queue: Patrick Monette <pmonette@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#586940}
    
    TBR=chrisha@chromium.org,thestig@chromium.org,qinmin@chromium.org,pmonette@chromium.org,asanka@chromium.org
    
    Change-Id: I9dd91dd84df4d7a7eddc8f2f6e264720e26b1e3b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 870998
    Reviewed-on: https://chromium-review.googlesource.com/1195436Reviewed-by: default avatarReid Kleckner <rnk@chromium.org>
    Commit-Queue: Reid Kleckner <rnk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#587119}
    6ab174bd
conflicts_handler.h 3.32 KB