• Matt Menke's avatar
    Restructure UnescapeURLWithAdjustmentsImpl(). · 6e8dbd1d
    Matt Menke authored
    In particular, unescape entire unicode characters at once, and then
    compare against unescape blacklists, rather than the other way around,
    to simplify code and avoid the tree structure of the old code. This
    will also allow the method to use icu's code point classification
    logic, at some point in the future.
    
    Also separate out comparing against the character blacklist and UTF-8
    character decoding into separate methods, and add a few more test cases
    to unittest.
    
    The method itself should behave exactly the same as before.
    
    Bug: 824715
    Change-Id: I5311f25bfda4132b122ec4a079740adf093099a3
    Reviewed-on: https://chromium-review.googlesource.com/998014
    Commit-Queue: Matt Menke <mmenke@chromium.org>
    Reviewed-by: default avatarMatt Giuca <mgiuca@chromium.org>
    Reviewed-by: default avatarHelen Li <xunjieli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551029}
    6e8dbd1d
escape.h 6.58 KB