• Nate Fischer's avatar
    AW: block malicious unwanted software · 6f1789c0
    Nate Fischer authored
    This adds support in WebView for blocking Malicious Unwanted Software
    (MUwS, UwS) AKA "Harmful software" via Safe Browsing.
    
    In this CL, we do the following:
    
     * Add new strings for the quiet MUwS interstitial (which is only used
       by WebView). These strings live in assets/stored-locales/ in the APK.
     * Whitelist the quiet MUwS strings (from the previous bullet point) as
       well as the previously chrome-only loud MUwS strings. These strings
       move from assets/locales/ (compressed, chrome-only resources) to
       assets/stored-locales/ (uncompressed, chrome+webview resources) in
       the APK.
     * Change WebView's declared list of threats to include MUwS
     * Change testSafeBrowsingDoesNotBlockUnwantedSoftwarePages, since this
       assertion is no longer valid. Change this to ensure we *do* block
       MUwS pages
     * Add a new test to ensure we can show quiet interstitials for MUwS
     * Change SafeBrowsingQuietErrorUI to respond to MUwS, and refactor it
       to be more similar to the LoudErrorUI.
    
    This change causes the following APK size changes (measurements taken
    with is_official_build = true), after unzipping the APKs with `unzip -lv
    $APK | grep 'pak'`.
    
    Monochrome:
     * assets/locales/en-US.pak: 20068 -> 19926 (-142) (improvement)
     * assets/stored-locales/en-US.pak: 7773 -> 8472 (+669)
    SystemWebViewGoogle:
     * assets/stored-locales/en-US.pak: 7773 -> 8472 (+669)
    
    A later follow-up will add this page to chrome://interstitials.
    
    Bug: 729268
    Bug: 729271
    Bug: 729272
    Test: run_webview_instrumentation_test_apk -f SafeBrowsingTest#*
    Test: Manual - load big and small interstitials, verify it looks correct
    Change-Id: I79e81f48d8b2ceb1ddcad7fab2d3bed3fcb479ae
    Reviewed-on: https://chromium-review.googlesource.com/1182945
    Commit-Queue: Nate Fischer <ntfschr@chromium.org>
    Reviewed-by: default avatarTao Bai <michaelbai@chromium.org>
    Reviewed-by: default avatarChangwan Ryu <changwan@chromium.org>
    Reviewed-by: default avatarNathan Parker <nparker@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#585268}
    6f1789c0
aw_url_checker_delegate_impl.cc 6.69 KB