• David Tseng's avatar
    Allow capture of f1-f12 · 71057143
    David Tseng authored
    History:
    At some point in the past, SpokenFeedbackEventRewriter did not have the notion of |capture| (a boolean set by a calling extension). As a result, we had to hard code values into the rewriter so that they get rewritten by things like KeyboardDrivenEventRewriter. For example, F1->back.
    
    This leads to us not being able to capture and prevent default on F1-F12 which map to hardware keys.
    
    Bug: 687748
    Test: Search+o, k; verify f1-f12 announce and don't trigger.
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: I3ca70a8fc1159f9b5f60332ef5a77ecfe95482b7
    Reviewed-on: https://chromium-review.googlesource.com/905283Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: David Tseng <dtseng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#537582}
    71057143
spoken_feedback_event_rewriter.cc 3.89 KB