Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Submit feedback
  • Sign in / Register
T
tangled
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • eriksson monteiro
  • tangled
  • Repository

Switch branch/tag
  • tangled
  • components
  • resources
  • default_200_percent
  • omnibox
  • omnibox_http.png
Find file HistoryPermalink
  • sdefresne's avatar
    Revert of Delete pre-MD code from OmniboxResultView (patchset #9 id:160001 of... · 7ae88a32
    sdefresne authored Oct 07, 2016
    Revert of Delete pre-MD code from OmniboxResultView (patchset #9 id:160001 of https://codereview.chromium.org/2365263006/ )
    
    Reason for revert:
    The downstream Chrome on iOS code has never been ported to the new vector icon and still use MD raster icon. This CL breaks Chrome on iOS downstream (due to missing resources and removal of GetIcon() method).
    
    Original issue's description:
    > Delete pre-MD code from OmniboxResultView
    >
    > BUG=648281
    >
    > Committed: https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707
    > Cr-Commit-Position: refs/heads/master@{#423690}
    
    TBR=pkasting@chromium.org,blundell@chromium.org,sky@chromium.org,estade@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=648281
    
    Review-Url: https://codereview.chromium.org/2399333002
    Cr-Commit-Position: refs/heads/master@{#423819}
    7ae88a32
omnibox_http.png 243 Bytes

Download (243 Bytes)

omnibox_http.png

Replace omnibox_http.png

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.