• Dan Beam's avatar
    Local NTP: make Enter on (X) remove suggestion button via keyboard work · 830328b1
    Dan Beam authored
    FWIW: I tried using capturing (true as third arg to addEventListener)
    and stopPropagation()/e.defaultPrevented. Because keypress seems to
    be handled before click, it didn't make a difference. So I landed at
    target filtering. This has the benefit of never navigating for
    elements we don't add to this list, but with the detriment of needing
    to explicitly add any new UI elements.
    
    R=mahmadi@chromium.org
    
    Fixed: 1012996
    Change-Id: Ie36a90210eee8238d05d026bf370a8bc95160a2c
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851228Reviewed-by: default avatarMoe Ahmadi <mahmadi@chromium.org>
    Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
    Commit-Queue: Dan Beam <dbeam@chromium.org>
    Auto-Submit: Dan Beam <dbeam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#704477}
    830328b1
local_ntp.js 60.9 KB