-
https://codereview.chromium.org/969843002/finnur authored
Reason for revert: Causes test to consistently time out. https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/35869 [ RUN ] ChromeWhispernetClientTest.EncodeAndDecode [724:3320:0303/204246:WARNING:data_reduction_proxy_config.cc(240)] SPDY proxy OFF at startup [3956:4296:0303/204248:ERROR:singleton_hwnd.cc(43)] Cannot create windows on non-UI thread! [724:4156:0303/204249:INFO:CONSOLE(5)] "Not allowed to load local resource: chrome://resources/css/text_defaults.css", source: chrome-extension://bpfmnplchembfbdgieamdodgaencleal/background.html (5) [724:4156:0303/204249:INFO:CONSOLE(83)] "init: Starting Nacl bridge.", source: chrome-extension://bpfmnplchembfbdgieamdodgaencleal/js/init.js (83) [2012:2524:0303/204249:ERROR:singleton_hwnd.cc(43)] Cannot create windows on non-UI thread! [2012:2832:0303/204249:ERROR:pnacl_translation_resource_host.cc(135)] Got invalid platformfilefortransit [724:4156:0303/204253:INFO:CONSOLE(65)] "init: Nacl ready!", source: chrome-extension://bpfmnplchembfbdgieamdodgaencleal/js/init.js (65) [724:4156:0303/204254:INFO:CONSOLE(26)] "Configuring encoder and decoder for client E77A9C58-00C9-4A99-AC57-1353FB0B918D", source: chrome-extension://bpfmnplchembfbdgieamdodgaencleal/js/init.js (26) [223/223] ChromeWhispernetClientTest.EncodeAndDecode (TIMED OUT) Original issue's description: > 1. Token CRCs are not handled correctly. This adds the corrected Whispernet binary (from cl/87383487), and a test to confirm the correct behavior. > > 2. If we get tokens that require more than one padding character, the padding will not be completely removed when appropriate. This is a simple change in the js. > > BUG=463218 > > Committed: https://crrev.com/6e37f17aa09f5244315d6eb84fa305154bc65062 > Cr-Commit-Position: refs/heads/master@{#319015} TBR=rkc@chromium.org,ckehoe@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463218 Review URL: https://codereview.chromium.org/979723002 Cr-Commit-Position: refs/heads/master@{#319032}
87bd8b46