GitLab

Class ImageLoader is singleton. It creates a new PiexLoader() when its
singleton instance is created, then passes it to the only user of that
PiexLoader, namely ImageRequestTask, on each image loader request.

But the PiexLoader passed is a singleton instance, because ImageLoader
is a singleton instance ;)

Remove this leaky abstraction. ImageLoader does not need to know about
PiexLoader. That is an internal detail of ImageRequestTask, and it can
create its own PiexLoader() singleton instance. Do that, and fix BUILD
rule deps: image_request_task depends on piex_loader, end of story.

No change in behavior. Covered by existing tests.

Bug: 1132695
No-try: true
Change-Id: I2b5ccfabe24d7ccaca2ed0ef01d2266b6e1ff25d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437579
Commit-Queue: Noel Gordon <noel@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Auto-Submit: Noel Gordon <noel@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811621}