Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Submit feedback
  • Sign in / Register
T
tangled
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • eriksson monteiro
  • tangled
  • Repository

Switch branch/tag
  • tangled
  • third_party
  • blink
  • web_tests
  • fast
  • canvas
  • canvas-drawImage-video-reset-expected...
Find file HistoryPermalink
  • Juanmi Huertas's avatar
    If the backend texture is the same we let skia take care of it · 96c82633
    Juanmi Huertas authored Sep 23, 2019
    We are now using SharedImage to hold the image for the video renderer,
    https://chromium-review.googlesource.com/c/chromium/src/+/1616978.
    That change, together with the change that made the video be deferred, and
    therefore, use the paintRecorder, let us safely remove the workaround.
    
    There was nevertheless the issue of texture lifetime to extend the texture.
    If the backend texture is the same in the SkImage and the one contained
    in the cache, we will let skia release it. If they are different, cache has
    to destroy their own texture, and the one in skia will survive the delete.
    
    Bug: 974656, 991792, 993774, 994516, 996083, 1004780
    Change-Id: I10b4165febf14a158584eb2b05cdb8c75c59175e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815734Reviewed-by: default avatarDan Sanders <sandersd@chromium.org>
    Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
    Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#698933}
    96c82633
canvas-drawImage-video-reset-expected.png 3.41 KB

Download (3.41 KB)

canvas-drawImage-video-reset-expected.png

Replace canvas-drawImage-video-reset-expected.png

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.