• David Benjamin's avatar
    Split URL_REQUEST_DELEGATE into per-delegate logs. · 9776ca20
    David Benjamin authored
    Before, one must guess from context which delegate was called:
    
    t=2141 [st=  0] +REQUEST_ALIVE  [dt=301]
                     --> priority = "HIGHEST"
                     --> url = "https://example.com/"
    t=2141 [st=  0]    URL_REQUEST_DELEGATE  [dt=1]
    t=2142 [st=  1]   +URL_REQUEST_START_JOB  [dt=298]
                       --> load_flags = 18432 (MAIN_FRAME_DEPRECATED | MAYBE_USER_GESTURE)
                       --> method = "GET"
                       --> url = "https://example.com/"
    t=2142 [st=  1]      URL_REQUEST_DELEGATE  [dt=0]
    t=2142 [st=  1]      HTTP_CACHE_GET_BACKEND  [dt=0]
    t=2142 [st=  1]      HTTP_CACHE_OPEN_ENTRY  [dt=0]
                         --> net_error = -2 (ERR_FAILED)
    
    Now it is spelled out explicitly:
    
    t=2141 [st=  0] +REQUEST_ALIVE  [dt=301]
                     --> priority = "HIGHEST"
                     --> url = "https://example.com/"
    t=2141 [st=  0]    NETWORK_DELEGATE_BEFORE_URL_REQUEST  [dt=1]
    t=2142 [st=  1]   +URL_REQUEST_START_JOB  [dt=298]
                       --> load_flags = 18432 (MAIN_FRAME_DEPRECATED | MAYBE_USER_GESTURE)
                       --> method = "GET"
                       --> url = "https://example.com/"
    t=2142 [st=  1]      NETWORK_DELEGATE_BEFORE_START_TRANSACTION  [dt=0]
    t=2142 [st=  1]      HTTP_CACHE_GET_BACKEND  [dt=0]
    t=2142 [st=  1]      HTTP_CACHE_OPEN_ENTRY  [dt=0]
                         --> net_error = -2 (ERR_FAILED)
    
    (Okay, I cheated and made the "before" example by editting the "after" one, but
    whatever.)
    
    Bug: none
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: Ie5fe7b4405c2389eaece479ff1c93774fe18b8ba
    Reviewed-on: https://chromium-review.googlesource.com/1096083Reviewed-by: default avatarMatt Menke <mmenke@chromium.org>
    Commit-Queue: David Benjamin <davidben@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#566632}
    9776ca20
url_request_job.cc 25 KB