GitLab

This method is using /deep/ which only worked in Shadow DOM v0. WebUI has
been using SDv1 since M72, and this test is silently doing nothing (does not
find any iron-icons to assert on).

Moreover, running additional checks after every test is a questionable
pattern.
 - The state of the DOM is not necessarily valid/useful at the end
   of a unit test (see workaround removed in site_details_permission_test.js).
 - Such checks often confuse developers by throwing an error only if another
   error has happened earlier (which affects the DOM state).
 - Given that these tests are silently injected by the PolymerTest base class
   developers often are not aware that these checks are even happening.

Overall, I think these speculative tests are not worth their maintenance burden.

Bug: 885401
Change-Id: I2574d690dc5596513bc089efd1738805ccd0404d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863673Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707248}