• Victor Fei's avatar
    Reland "Fire WIN HIDE event only on ignored ancestor" · a2e28ea8
    Victor Fei authored
    This is a reland of 4856b612
    The original changed was reverted due to 'win-asan' bot flaky test
    for IA2_EVENT_TEXT_INSERTED/REMOVED and EVENT_OBJECT_REORDER for
    my newly added test 'aria-hidden-descendants-already-ignored.html'.
    It was only flaky for 'win-asan' bot and not flaky on normal win10
    bot. This reland suppresses these flaky events since the tests do
    not require them.
    
    Original change's description:
    > Fire WIN HIDE event only on ignored ancestor
    >
    > Google drive expand/collapse state is not being announced due to
    > excessive HIDE/SHOW/REORDER events flooding NVDA, and NVDA end up
    > discarding most events.
    >
    > For example, if aria-hidden="true" is set on an ancestor node, which
    > would cause that node many of its descendants to be set to IGNORED
    > state which triggering too many EVENT_OBJECT_HIDE and causes NVDA
    > to drop the events. In reality, we only want EVENT_OBJECT_HIDE to be
    > generated on the ancestor node where aria-hidden="true" is set, so
    > not to flood and confuse NVDA with excessive events.
    >
    > This change fixes the above issue by firing EVENT_OBJECT_HIDE on the
    > root should the entire subtree changes to IGNORED state.
    >
    > Suppressing excessive SHOW/REORDER events will be addressed in follow up
    > patches.
    >
    > AX-RelNotes: NVDA can now announce Google drive "My Drive" expand/
    > collapse state.
    >
    > Bug: 1019420
    > Change-Id: I4fdabd6740630a149c1b22cdb3180d2f75807b10
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309450
    > Commit-Queue: Victor Fei <vicfei@microsoft.com>
    > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    > Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
    > Cr-Commit-Position: refs/heads/master@{#795017}
    
    Bug: 1019420
    Change-Id: Iae15521bb69645eef9e3fc4aad4b6bd64345c0f7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340282
    Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
    Reviewed-by: default avatarAaron Leventhal <aleventhal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#796380}
    a2e28ea8
aria-hidden-descendants-expected-win.txt 258 Bytes