• Hugo Holgersson's avatar
    Snav: Convert all snav*iframe*.html tests to snav-testharness.js · a417a16c
    Hugo Holgersson authored
    The changes to snav-testharness.js lets us assert navigations
    in and out of iframes:
    
     1) To be able to test focus movements in and out of iframes,
        we need to listen for 'keyup'-events on the document where
        focus is _about_to_go_.
    
        'keyup' targets the currently focused document. When 'keyup'
        comes, 'keydown' has already changed focus to the new document.
    
     2) Previously each movement had its own async_test(). Now we use
        one async_test() with many "test steps": one for each movement.
        This helps us avoid tricky (mis)usage of testharness.js's
        fetch_tests_from_window().
    
    The changes to the HTML files are mostly mechanical except that
    I gave some elements new or renamed ids so they become easier
    to distinguish when debugging.
    
    Once we've fixed Issue 801162, the tests' expectations will change:
    We want spatnav to first _focus_ the iframe (before scrolling it
    or searching inside of it).
    
    Bug: 803086, 891658, 801162
    Change-Id: Ib53bb224398510b5744927a5d892381870fa4690
    Reviewed-on: https://chromium-review.googlesource.com/c/1314469
    Commit-Queue: Hugo Holgersson <hugoh@vewd.com>
    Reviewed-by: default avatarFredrik Söderquist <fs@opera.com>
    Cr-Commit-Position: refs/heads/master@{#604962}
    a417a16c
snav-testharness.js 3.2 KB