• Sean Harrison's avatar
    Add missing enums to SettingsPageInteraction enum · aaa6ca07
    Sean Harrison authored
    Add:
    PRIVACY_SITE_SETTINGS_ALL
    PRIVACY_SITE_SETTINGS_AR
    PRIVACY_SITE_SETTINGS_VR
    
    These were missed in a previous CL and hits a DCHECK
    
    Add corresponding test to site_settings_page_test.js
    
    Merge all tests into one to remove flakiness, testing each logging call in a separate test was taking too long and causing sporadic timeouts resulting in flakiness.
    
    Now all logging checks are done by navigating around a single test instance and resetting proxy state, speed up removes all flakiness and was significant enough to allow the merging of all 4 split test suites without timeout concerns.
    
    Bug: 1046488, 1048858
    Change-Id: I074e2581d3489e179adfdc187e7165284ccc2685
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027447
    Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
    Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#738512}
    aaa6ca07
cr_settings_browsertest.js 51.4 KB