GitLab

In 1240638e, AVC keyframeness analysis result in MP4 was used instead of
MP4 keyframe metadata, but the conversion of the AVC frame to Annex-B
(and the conditional injection of SPS/PPS) still relied upon the MP4
keyframe metadata. Since that metadata could be incorrect, decode errors
could occur on some decoders due to missing SPS/PPS data for incorrectly
muxed AVC keyframes.

This change performs the bitstream analysis as part of frame conversion,
after converting to Annex-B, but before the conditional SPS/PPS
injection, and uses the analysis's keyframe result (if determined) to
condition the injection instead of the MP4 keyframe metadata.

BUG=889311

Change-Id: I1ef327ef7d399d5a9da552e0da4a58b0f0b04435
Reviewed-on: https://chromium-review.googlesource.com/1250171
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595176}