Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Submit feedback
  • Sign in / Register
T
tangled
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • eriksson monteiro
  • tangled
  • Repository

Switch branch/tag
  • tangled
  • third_party
  • blink
  • web_tests
  • fast
  • reflections
  • reflection-with-zoom-expected.png
Find file HistoryPermalink
  • Stephen Chenney's avatar
    Clamp sub-pixel borders accounting for zoom · b42410d0
    Stephen Chenney authored Mar 13, 2020
    A previous patch added clamping for sub-pixel borders to ensure they
    did not round to zero size. The change was done in paint code, leaving
    the borders as sub-pixel sized in layout. The code prior to that patch
    clamped the borders during style conversion but did not account for zoom,
    meaning borders disappeared under zoom.
    
    This change removes the clamping in paint and reverts to clamping in the
    style conversion code, only this time accounting for zoom when considering
    whether to clamp or not. This will prevent borders growing too large as
    content is made larger, while preventing sub-pixel borders from disappearing
    as content is made smaller.
    
    Design Doc: https://docs.google.com/document/d/1fAYkOFxp2Luh6OOoXxtwOehmvNRGNss58ibQtVXL0Tw/edit?usp=sharing
    
    Bug: 763402, 834489
    Change-Id: Iba2ae80b0a981736b93453c1058fd586ba10212c
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097514
    Commit-Queue: Stephen Chenney <schenney@chromium.org>
    Reviewed-by: default avatarRune Lillesveen <futhark@chromium.org>
    Reviewed-by: default avatarIan Kilpatrick <ikilpatrick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#750231}
    b42410d0
reflection-with-zoom-expected.png 190 KB

Download (190 KB)

reflection-with-zoom-expected.png

Replace reflection-with-zoom-expected.png

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.