GitLab

The original CL caused a test failure in
DetachToBrowserTabDragControllerTest.DetachToOwnWindow. This was due to a bug in
the test itself, which was generating an incorrect mouse-up event. This CL fixes
the test to delay generation of the mouse-up event until the new tab dragging
window has been detached.

> WebContentsView::Focus() is supposed to update the first responder of the
> Window, not make the window focused. The latter should go through
> WebContentsDelegate::ActivateContents().
>
> This logic is usually a no-op because the window receiving the call is the
> active window. But in the case where the user quickly switches windows, this can
> cause the old window to re-take focus.
>
> This logic was added in 2009 not because it had the right semantics, but to
> match the behavior of Windows: http://codereview.chromium.org/165492.
>
> Bug: 859614
> Change-Id: I2bc44a825d93159d774c632da17cc2f2d151fc3a
> Reviewed-on: https://chromium-review.googlesource.com/1124772
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573344}

Bug: 859614
Change-Id: I441a00ad015eb3559718b448fc42f98827beee35
Reviewed-on: https://chromium-review.googlesource.com/1132106Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574159}