GitLab

This reverts commit 07b2231e.

Reason for revert:

We need to be more conservative with plugin behaviour changes.
TODO: document the process, then attempt to re-land this change
via that process.

Original change's description:
> drop unnecessary realpath usage in the FindBadConstructs plugin
>
> All we need to do is ensure that there's a leading '/' in the path, we
> don't expect the path to exist necessarily, and we don't need to resolve
> symlinks.  We just want to be able to search for directories by doing a
> string search of the form "/foo/".  And since we don't use realpath
> anymore, this should work with distributed compilation systems like icecc.
>
> This will also avoid mis-classification of files in chromium checkouts
> that are inside a directory with the same name as one of the so-called
> "banned" directories, eg a checkout in /home/gen/chromium/.
>
> BUG=583454

Change-Id: Ic840387bb2244d967e66fd078684c56435fe940a
Reviewed-on: https://chromium-review.googlesource.com/986435Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#546928}