Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Submit feedback
  • Sign in / Register
T
tangled
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • eriksson monteiro
  • tangled
  • Repository

Switch branch/tag
  • tangled
  • ui
  • resources
  • default_200_percent
  • cros
  • menu_droparrow.png
Find file HistoryPermalink
  • John Budorick's avatar
    Revert "Remove menu_marker from MenuButton." · 5148d1fe
    John Budorick authored Nov 10, 2018
    This reverts commit 32758758.
    
    Reason for revert: causes compile failures on windows similar to the ones that appeared in the CQ runs, e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20x64%20Builder/58688
    
    Original change's description:
    > Remove menu_marker from MenuButton.
    > 
    > This is always false except for in tests and menu_example.cc which is
    > not used. This helps simplify MenuButton for the Button cleanup task.
    > 
    > Bug: 901183
    > Change-Id: If5a3cf7b6ba1ce5618548d112df1c4404b2ae181
    > Reviewed-on: https://chromium-review.googlesource.com/c/1324375
    > Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    > Reviewed-by: Robert Flack <flackr@chromium.org>
    > Reviewed-by: Trent Apted <tapted@chromium.org>
    > Reviewed-by: Michael Wasserman <msw@chromium.org>
    > Commit-Queue: Charlene Yan <cyan@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#607061}
    
    TBR=msw@chromium.org,flackr@chromium.org,oshima@chromium.org,tapted@chromium.org,cyan@chromium.org
    
    Change-Id: I9c311a3c8cea56c7670b2dace3e0410618151034
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 901183
    Reviewed-on: https://chromium-review.googlesource.com/c/1330841Reviewed-by: default avatarJohn Budorick <jbudorick@chromium.org>
    Commit-Queue: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607072}
    5148d1fe
menu_droparrow.png 100 Bytes

Download (100 Bytes)

menu_droparrow.png

Replace menu_droparrow.png

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.