• Ryan Harrison's avatar
    Improve matching of similar characters in PDF search · c6082cfb
    Ryan Harrison authored
    This CL changes the ICU collator being used for text searching in the
    PDF viewer from the default to the 'search' one. This is the same
    collator used in Blink, and it folds together similar looking
    characters in a locale specific way, so that things like accented and
    unaccented vowles will match or not match dependent on the
    expectations of the user locale.
    
    Additionally, when searching single and double quotation characters
    are being simplified to the ASCII forms of them to make matching
    between defferent types of quotes work better. Quotation marks are a
    known limitation of the search collator and this workaround is based
    off a similar solution that exists in Blink to improve matching.
    
    BUG=chromium:142627
    
    Change-Id: I399ea1f0bacb58434b468866127a91ccb6213e99
    Reviewed-on: https://chromium-review.googlesource.com/c/1281178
    Commit-Queue: Ryan Harrison <rharrison@chromium.org>
    Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
    Reviewed-by: default avatarJochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#601157}
    c6082cfb