• Daniel Hosseinian's avatar
    Split PDF annotations test files · d209add6
    Daniel Hosseinian authored
    The original tests in PDFExtensionJSTest.AnnotationsFeatureEnabled
    tested the behaviors of the ink controller, and did not clear the DOM.
    
    The new tests, which only test parts of the UI inside the toolbar, clear
    the DOM, exposing the tests to potential flakiness if any calls are
    made to the plugin near when the DOM is being cleared. When the DOM is
    cleared, references to the plugin's members, including the postMessage()
    function, vanish.
    
    Bug: 1136319
    Change-Id: I3e6b4dd8c1ef8a23281c100c4a8748d36e642365
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478104
    Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
    Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#821114}
    d209add6
annotations_toolbar_test.js 4.38 KB