• Takuto Ikuta's avatar
    Do not use rsp files for windows compile · d2164444
    Takuto Ikuta authored
    Creating and deleting rsp files is time consuming part when building on windows with warmed goma backend cache.
    To reduce such bottleneck, we can use all compiler flags directory in command line instead of using rsp file.
    
    This CL keeps using rsp file for linking because linking flags can be longer than compiles and the number of linking is relatively small compared to compile.
    
    I took 3 time build stats for 'chrome' on 48 thread Z840 windows 10 with following args.gn and -j 500.
    ```
    goma_dir = "C:\\src\\goma_client\\client\\out\\Release"
    is_component_build = true
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 0
    target_cpu = "x86"
    use_goma = true
    
    is_clang = false
    enable_nacl = false
    use_lld = true
    ```
    
    * With this CL
    TotalSeconds: 279.9604737
    TotalSeconds: 279.4099064
    TotalSeconds: 273.8253059
    Avg: 277.731895333333
    
    * Without this CL
    TotalSeconds: 325.0155664
    TotalSeconds: 319.4094433
    TotalSeconds: 299.9709
    Avg: 314.798636566667
    
    
    Bug: 796021
    Change-Id: Ice959c196b6879b39962a3b628cdcf531884ec36
    Reviewed-on: https://chromium-review.googlesource.com/832593Reviewed-by: default avatarNico Weber <thakis@chromium.org>
    Reviewed-by: default avatarScott Graham <scottmg@chromium.org>
    Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
    Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#529137}
    d2164444
BUILD.gn 15.9 KB