• dpapad's avatar
    Settings: Move more privacy subpages/dialogs to lazy_load.html. · e17d58c8
    dpapad authored
    Specifically moving
     - clear_browsing_data_dialog/clear_browsing_data_dialog.html
     - privacy_page/cookies_page.html
     - privacy_page/security_page.html
     - site_settings/all_sites.html
    
    Which results in 15.4% less JS/HTML code loaded during Settings
    startup (measured on Linux builds)
    
    vulcanized.html: 342K -> 286K  (-16.4%)
    crisper.js: 390K -> 333K (-14.6%)
    
    lazy_load.vulcanized.html: 153K -> 209K (+27%)
    lazy_load.crisper.js: 189K -> 246K (+30%)
    
    Also fixing a bug that was revealed as a result of these changes
    where <settings-ui> was not properly clearing some global state
    when it was detached from the DOM, causing test failures.
    
    Bug: 1026064,1032584
    Change-Id: Ibf6ef69916ae7a656b9b2576947294bea87ef5c5
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090840Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
    Commit-Queue: dpapad <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#748417}
    e17d58c8
settings_ui.js 8.94 KB