• Zain Afzal's avatar
    Removed concept of a singular writable file. · e6a57940
    Zain Afzal authored
    As part of the go/bl-file-navigation-order effort, this CL dose 2 major
    things:
        * Removes openFile from the delegate in favour of existing on the
          ReceivedFileList.
        * Removes the concept of the media app only having 1 writable file.
    
    The idea that the media app only has 1 writable file was from a older
    security model which has since been abandoned. As such this CL updates
    the language used and variable names to better reflect how the media app
    actually works. Any file can be writable but there is only ever 1
    "current" file which is what the app is displaying at any given moment.
    
    Part of this change also removes some legacy code which ensured that
    the "currentlyWritableFile" was always the first file in the list which
    is not required as the google3 side no longer expects this. Some
    test code relied on this assumption however and was updated accordingly
    as were some functions such as "firstReceivedItem" which were always
    expecting the first file in the file list to be the "current" file.
    
    Completely unrelated to this change is the addition of the
    "suppressCrashReports" codepath, which was added due to the fact that
    the "FileThatBecomesDirectory" test was triggering a invalid crash
    report causing the test to fail. This cl seemed to adjust the test
    timing such that this crash report was getting triggered before the
    test ended whereas it was ignored previously.
    
    BUG: b/151880563, b/165720635
    Change-Id: I89c8ebfecab73dab4ffae0a77ceb434489a1b85b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524625
    Commit-Queue: Zain Afzal <zafzal@google.com>
    Reviewed-by: default avatarBugs Nash <bugsnash@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#828616}
    e6a57940
launch.js 31.6 KB