• rbpotter's avatar
    WebUI Polymer2: Make CrSettingsAllSitesTest work in Polymer 2. · f38486f9
    rbpotter authored
    This CL addresses 3 bugs that were causing CrSettingsAllSitesTest to
    fail with Polymer 2:
    (1) async() call in basic_page.js did not pause for all of layout on
    the first call in Polymer 2 (likely due to layout not being finished
    by the end of attached()). This was also causing a runtime error on
    content, languages, and other subpages.
    (2) The test itself also called async(), which did not wait long
    enough for rendering to complete before checking various elements.
    (3) The computed subpageScrollTarget was set earlier in Polymer 2, as
    its computation function was called with some parameters undefined.
    This resulted in overriding the non-null, defined default scroll
    target for iron-list with an undefined scroll target, which caused
    toggleScrollListener(), called from the resize handler in iron-list,
    to fail.
    
    Bug: 875452
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I2a09020a798fdf806a98c7c9d9d32547b3fa310f
    Reviewed-on: https://chromium-review.googlesource.com/1208448
    Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
    Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#590475}
    f38486f9
pending.js 2.19 KB