-
W. James MacLean authored
At present, the implementation of destroyImpl() in guest_view_iframe.js calls handleCallback() in the *middle* of the function, meaning remaining items in the action queue may complete before destroyImpl() finishes updating the state, leading to subsequent commands being dropped if functions like create/attach encounter the non-updated state. This fixes a regression introduced in https://chromium-review.googlesource.com/c/chromium/src/+/528392. It's not obvious if it introduced any failures, but the original CL bypassed browser tests as extensions/renderer/BUILD.gn was missing the relevant files (restored in https://chromium-review.googlesource.com/c/chromium/src/+/812109). Bug: Change-Id: I83db799b73174d3e996677333e01192bf5321460 Reviewed-on: https://chromium-review.googlesource.com/812005Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#522438}
f68022ef