Commit 003e171f authored by Luciano Pacheco's avatar Luciano Pacheco Committed by Commit Bot

Sentence case for [My|Linux|Play] files

Essentially changing:
 * My Files => My files.
 * Linux Files => Linux files.
 * Play Files => Play files.


Bug: 864299
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ic3c614f654ae0a7cfaa5efb67d6f966acfccc721
Reviewed-on: https://chromium-review.googlesource.com/1139456Reviewed-by: default avatarJoel Hockey <joelhockey@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575558}
parent d962927b
......@@ -196,8 +196,8 @@
</message>
<!-- File Manager -->
<message name="IDS_FILE_BROWSER_ANDROID_FILES_ROOT_LABEL" desc="A label for the 'Play Files' root which shows Android files. 'Play' in this label is an abbreviation of 'Google Play', so it should not be translated.">
Play Files
<message name="IDS_FILE_BROWSER_ANDROID_FILES_ROOT_LABEL" desc="A label for the 'Play files' root which shows Android files. 'Play' in this label is an abbreviation of 'Google Play', so it should not be translated. Use sentence case.">
Play files
</message>
<message name="IDS_FILE_BROWSER_SHOW_ALL_ANDROID_FOLDERS_OPTION" desc="A label for an option menu item to show all Android folders. By default, only several folders are visible to users, and users will click this option menu item to show all folders. 'Play' in this label is an abbreviation of 'Google Play', so it should not be translated.">
Show all Play folders
......@@ -253,11 +253,11 @@
<message name="IDS_FILE_BROWSER_DOWNLOADS_DIRECTORY_LABEL" desc="Downloads local directory label.">
Downloads
</message>
<message name="IDS_FILE_BROWSER_LINUX_FILES_ROOT_LABEL" desc="A label for the 'Linux Files' root which shows crostini files.">
Linux Files
<message name="IDS_FILE_BROWSER_LINUX_FILES_ROOT_LABEL" desc="A label for the 'Linux files' root which shows crostini files. Use sentence case.">
Linux files
</message>
<message name="IDS_FILE_BROWSER_MY_FILES_ROOT_LABEL" desc="A label for the 'My Files' root which is parent of Downloads, Linux and Android files.">
My Files
<message name="IDS_FILE_BROWSER_MY_FILES_ROOT_LABEL" desc="A label for the 'My files' root which is parent of Downloads, Linux and Android files. Use sentence case.">
My files
</message>
<message name="IDS_FILE_BROWSER_MEDIA_VIEW_IMAGES_ROOT_LABEL" desc="A label for the 'Images' root of media views.">
Images
......
......@@ -6,8 +6,8 @@
/** Test constructor and default public attributes. */
function testEntryList(testReportCallback) {
const entryList = new EntryList('My Files', 'my_files');
assertEquals('My Files', entryList.label);
const entryList = new EntryList('My files', 'my_files');
assertEquals('My files', entryList.label);
assertEquals('entry-list://my_files', entryList.toURL());
assertEquals('my_files', entryList.rootType);
assertFalse(entryList.isNativeType);
......@@ -48,7 +48,7 @@ function testEntryList(testReportCallback) {
/** Tests method EntryList.getParent. */
function testEntryListGetParent(testReportCallback) {
const entryList = new EntryList('My Files', 'my_files');
const entryList = new EntryList('My files', 'my_files');
let callbackTriggered = false;
entryList.getParent(parentEntry => {
// EntryList should return itself since it's a root and that's what the web
......@@ -61,7 +61,7 @@ function testEntryListGetParent(testReportCallback) {
/** Tests method EntryList.addEntry. */
function testEntryListAddEntry() {
const entryList = new EntryList('My Files');
const entryList = new EntryList('My files');
assertEquals(0, entryList.children.length);
const fakeRootEntry = createFakeDisplayRoot();
......@@ -78,7 +78,7 @@ function testEntryListAddEntry() {
/** Tests methods to remove entries. */
function testEntryListRemoveEntry() {
const entryList = new EntryList('My Files');
const entryList = new EntryList('My files');
const fakeRootEntry = createFakeDisplayRoot();
const fakeVolumeInfo = {
......@@ -95,7 +95,7 @@ function testEntryListRemoveEntry() {
* Tests methods findIndexByVolumeInfo, removeByVolumeType, removeByRootType.
*/
function testEntryFindIndex() {
const entryList = new EntryList('My Files');
const entryList = new EntryList('My files');
const fakeRootEntry = createFakeDisplayRoot();
const downloadsVolumeInfo = {
......@@ -116,7 +116,7 @@ function testEntryFindIndex() {
const fakeEntry = {
isDirectory: true,
rootType: VolumeManagerCommon.RootType.CROSTINI,
name: 'Linux Files',
name: 'Linux files',
toURL: function() {
return 'fake-entry://linux-files';
}
......@@ -145,7 +145,7 @@ function testEntryFindIndex() {
/** Tests method EntryList.getMetadata. */
function testEntryListGetMetadata(testReportCallback) {
const entryList = new EntryList('My Files');
const entryList = new EntryList('My files');
let modificationTime = null;
entryList.getMetadata(metadata => {
......@@ -330,7 +330,7 @@ function testEntryListAddEntrySetsPrefix() {
label: 'Fake Filesystem',
};
const volumeEntry = new VolumeEntry(fakeVolumeInfo);
const entryList = new EntryList('My Files', 'my_files');
const entryList = new EntryList('My files', 'my_files');
entryList.addEntry(volumeEntry);
assertEquals(1, entryList.children.length);
......
......@@ -17,8 +17,8 @@ loadTimeData.data = {
DRIVE_SHARED_WITH_ME_COLLECTION_LABEL: 'Shared with me',
DRIVE_RECENT_COLLECTION_LABEL: 'Recents',
DOWNLOADS_DIRECTORY_LABEL: 'Downloads',
LINUX_FILES_ROOT_LABEL: 'Linux Files',
MY_FILES_ROOT_LABEL: 'My Files',
LINUX_FILES_ROOT_LABEL: 'Linux files',
MY_FILES_ROOT_LABEL: 'My files',
RECENT_ROOT_LABEL: 'Recent',
MEDIA_VIEW_IMAGES_ROOT_LABEL: 'Images',
MEDIA_VIEW_VIDEOS_ROOT_LABEL: 'Videos',
......@@ -222,10 +222,10 @@ function testOrderAndNestItems() {
// 4. media_view:audio_root
// 5. /root/shortcut
// 6. /root/shortcut2
// 7. My-Files
// 7. My files
// -> Downloads
// -> Play Files
// -> Linux Files
// -> Play files
// -> Linux files
// 8. removable:hoge
// 9. archive:a-rar - mounted as archive
// 10. removable:fuga
......@@ -250,7 +250,7 @@ function testOrderAndNestItems() {
assertEquals('shortcut', model.item(4).label);
assertEquals('shortcut2', model.item(5).label);
assertEquals('My Files', model.item(6).label);
assertEquals('My files', model.item(6).label);
assertEquals('removable:hoge', model.item(7).label);
assertEquals('archive:a-rar', model.item(8).label);
......
......@@ -183,7 +183,7 @@ crostini.testErrorOpeningDownloadsWithCrostiniApp = (done) => {
// Validate error messages, click 'OK' to close. Ensure dialog closes.
assertEquals(
'To open files with Crostini App, ' +
'first copy to Linux Files folder.',
'first copy to Linux files folder.',
document.querySelector('.cr-dialog-text').innerText);
assertTrue(test.fakeMouseClick('button.cr-dialog-ok'));
return test.waitForElementLost('.cr-dialog-container.shown');
......
......@@ -48,7 +48,7 @@ loadTimeData.data = new Proxy(
'All files saved in this folder are backed up online automatically',
DRIVE_WELCOME_TITLE_ALTERNATIVE: 'Get 100 GB free with Google Drive',
EMPTY_FOLDER: 'Nothing to see here...',
ERROR_LINUX_FILES_CONNECTION: 'Unable to view Linux Files',
ERROR_LINUX_FILES_CONNECTION: 'Unable to view Linux files',
FILENAME_LABEL: 'File name',
GALLERY_CONFIRM_DELETE_ONE: 'Are you sure you want to delete "$1"?',
GALLERY_CONFIRM_DELETE_SOME: 'Are you sure you want to delete $1 items?',
......@@ -59,7 +59,7 @@ loadTimeData.data = new Proxy(
'utm_campaign=gsg',
IMAGE_FILE_TYPE: '$1 image',
INSTALL_NEW_EXTENSION_LABEL: 'Install new from the webstore',
LINUX_FILES_ROOT_LABEL: 'Linux Files',
LINUX_FILES_ROOT_LABEL: 'Linux files',
MANY_ENTRIES_SELECTED: '$1 items selected',
MANY_FILES_SELECTED: '$1 files selected',
METADATA_BOX_ALBUM_TITLE: 'Album',
......@@ -67,14 +67,14 @@ loadTimeData.data = new Proxy(
METADATA_BOX_MODIFICATION_TIME: 'Modified time',
MOVE_FILE_NAME: 'Moving $1...',
MOVE_ITEMS_REMAINING: 'Moving $1 items...',
MY_FILES_ROOT_LABEL: 'My Files',
MY_FILES_ROOT_LABEL: 'My files',
NAME_COLUMN_LABEL: 'Name',
OFFLINE_COLUMN_LABEL: 'Available offline',
OPEN_WITH_VERB_BUTTON_LABEL: 'Open with $1',
OK_LABEL: 'OK',
ONE_DIRECTORY_SELECTED: '1 folder selected',
ONE_FILE_SELECTED: '1 file selected',
OPENING_LINUX_FILES: 'Opening Linux Files...',
OPENING_LINUX_FILES: 'Opening Linux files...',
OPEN_LABEL: 'Open',
PLAIN_TEXT_FILE_TYPE: 'Plain text',
PREPARING_LABEL: 'Preparing',
......@@ -104,7 +104,7 @@ loadTimeData.data = new Proxy(
TOGGLE_HIDDEN_FILES_COMMAND_LABEL: 'Show hidden files',
UNABLE_TO_OPEN_CROSTINI_TITLE: 'Unable to open with $1',
UNABLE_TO_OPEN_CROSTINI:
'To open files with $1, first copy to Linux Files folder.',
'To open files with $1, first copy to Linux files folder.',
VIDEO_FILE_TYPE: '$1 video',
WAITING_FOR_SPACE_INFO: 'Waiting for space info...',
language: 'en',
......
......@@ -10,9 +10,9 @@ testcase.showMyFiles = function() {
const expectedElementLabels = [
'Recent: FakeItem',
'My Files: EntryListItem',
'My files: EntryListItem',
'Downloads: SubDirectoryItem',
'Linux Files: FakeItem',
'Linux files: FakeItem',
'Google Drive: DriveVolumeItem',
'My Drive: SubDirectoryItem',
'Shared with me: SubDirectoryItem',
......@@ -59,7 +59,7 @@ testcase.showMyFiles = function() {
},
// Check that My Files is displayed on breadcrumbs.
function(breadcrumbs) {
const expectedBreadcrumbs = 'My Files > Downloads';
const expectedBreadcrumbs = 'My files > Downloads';
const resultBreadscrubms =
breadcrumbs.map(crumb => crumb.text).join(' > ');
chrome.test.assertEq(expectedBreadcrumbs, resultBreadscrubms);
......@@ -104,7 +104,7 @@ testcase.hideSearchButton = function() {
},
// Select My Files folder.
function() {
const myFilesQuery = '#directory-tree [entry-label="My Files"]';
const myFilesQuery = '#directory-tree [entry-label="My files"]';
const isDriveQuery = false;
remoteCall.callRemoteTestUtil(
'selectInDirectoryTree', appId, [myFilesQuery, isDriveQuery],
......@@ -183,7 +183,7 @@ testcase.myFilesDisplaysAndOpensEntries = function() {
// Select My Files folder.
function(results) {
appId = results.windowId;
const myFilesQuery = '#directory-tree [entry-label="My Files"]';
const myFilesQuery = '#directory-tree [entry-label="My files"]';
const isDriveQuery = false;
remoteCall.callRemoteTestUtil(
'selectInDirectoryTree', appId, [myFilesQuery, isDriveQuery],
......@@ -193,7 +193,7 @@ testcase.myFilesDisplaysAndOpensEntries = function() {
function(result) {
chrome.test.assertTrue(result);
const downloadsRow = ['Downloads', '--', 'Folder'];
const crostiniRow = ['Linux Files', '--', 'Folder'];
const crostiniRow = ['Linux files', '--', 'Folder'];
remoteCall
.waitForFiles(
appId, [downloadsRow, crostiniRow],
......
......@@ -413,7 +413,7 @@ RemoteCallFilesApp.prototype.waitUntilCurrentDirectoryIsChanged = function(
function(path) {
// TODO(lucmult): Remove this once MyFiles flag is removed.
// https://crbug.com/850348.
const myFilesExpectedPath = '/My Files' + expectedPath;
const myFilesExpectedPath = '/My files' + expectedPath;
if(!(path === expectedPath || path === myFilesExpectedPath)) {
return pending(
caller, 'Expected path is %s got %s', expectedPath, path);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment