Add usecounters for window.history.pushState and window.history.replaceState and expose to UKM

Bug: 898982
Change-Id: I37d2006abe68282d9d068f7a19d7d501bd4ee5bd
Reviewed-on: https://chromium-review.googlesource.com/c/1299919
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605108}

chrome/browser/page_load_metrics/observers/use_counter/ukm_features.cc

@@ -60,6 +60,7 @@ bool IsAllowedUkmFeature(blink::mojom::WebFeature feature) {
           WebFeature::kDocumentDomainEnabledCrossOriginAccess,
           WebFeature::kSuppressHistoryEntryWithoutUserGesture,
           WebFeature::kCursorImageGT32x32, WebFeature::kCursorImageLE32x32,
+          WebFeature::kHistoryPushState, WebFeature::kHistoryReplaceState,
       }));
   return opt_in_features->count(feature);
 }

third_party/blink/public/platform/web_feature.mojom

@@ -2066,6 +2066,8 @@ enum WebFeature {
   kCSSValueAppearanceNoImplementationSkipBorder = 2614,
   kInstantiateModuleScript = 2615,
   kDynamicImportModuleScript = 2616,
+  kHistoryPushState = 2617,
+  kHistoryReplaceState = 2618,
   // Add new features immediately above this line. Don't change assigned
   // numbers of any item, and don't reuse removed slots.
   // Also, run update_use_counter_feature_enum.py in

third_party/blink/renderer/core/frame/history.cc

@@ -31,6 +31,7 @@
 #include "third_party/blink/renderer/core/frame/local_frame.h"
 #include "third_party/blink/renderer/core/frame/local_frame_client.h"
 #include "third_party/blink/renderer/core/frame/settings.h"
+#include "third_party/blink/renderer/core/frame/use_counter.h"
 #include "third_party/blink/renderer/core/inspector/console_message.h"
 #include "third_party/blink/renderer/core/loader/document_loader.h"
 #include "third_party/blink/renderer/core/loader/frame_loader.h"
@@ -212,6 +213,16 @@ void History::pushState(scoped_refptr<SerializedScriptValue> data,
                         ExceptionState& exception_state) {
   StateObjectAdded(std::move(data), title, url, ScrollRestorationInternal(),
                    WebFrameLoadType::kStandard, exception_state);
+  UseCounter::Count(GetFrame(), WebFeature::kHistoryPushState);
+}
+
+void History::replaceState(scoped_refptr<SerializedScriptValue> data,
+                           const String& title,
+                           const String& url,
+                           ExceptionState& exception_state) {
+  StateObjectAdded(std::move(data), title, url, ScrollRestorationInternal(),
+                   WebFrameLoadType::kReplaceCurrentItem, exception_state);
+  UseCounter::Count(GetFrame(), WebFeature::kHistoryReplaceState);
 }
 
 KURL History::UrlForState(const String& url_string) {

third_party/blink/renderer/core/frame/history.h

@@ -68,10 +68,7 @@ class CORE_EXPORT History final : public ScriptWrappable,
   void replaceState(scoped_refptr<SerializedScriptValue> data,
                     const String& title,
                     const String& url,
-                    ExceptionState& exception_state) {
-    StateObjectAdded(std::move(data), title, url, ScrollRestorationInternal(),
-                     WebFrameLoadType::kReplaceCurrentItem, exception_state);
-  }
+                    ExceptionState& exception_state);
 
   void setScrollRestoration(const String& value, ExceptionState&);
   String scrollRestoration(ExceptionState&);

tools/metrics/histograms/enums.xml

@@ -20639,6 +20639,8 @@ Called by update_net_error_codes.py.-->
   <int value="2614" label="CSSValueAppearanceNoImplementationSkipBorder"/>
   <int value="2615" label="InstantiateModuleScript"/>
   <int value="2616" label="DynamicImportModuleScript"/>
+  <int value="2617" label="HistoryPushState"/>
+  <int value="2618" label="HistoryReplaceState"/>
 </enum>
 
 <enum name="FeaturePolicyFeature">