Skip to content

GitLab

T
tangled
Commit 00de0eea authored by Dan Harrington's avatar Dan Harrington Committed by Commit Bot
Browse files
Options

sort suppressions.xml 

suppress.py outputs XML tags in sorted order, which makes seeing the
changes difficult when suppressions.xml is not sorted. I've re-ordered
tags in this file so that running suppress.py results in no diff beyond
missing comments.

Added a note at the top to suggest inserting tags in sorted order.

There should be no material changes to suppressions.xml in this CL.

Change-Id: I43b8ad4928bc6262e486bcba71aa2c0bb282c1f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947227Reviewed-by: default avatarPeter Wen <wnwen@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720740}
parent e576f1de
Hide whitespace changes
Inline Side-by-side
Showing with 79 additions and 81 deletions
build/android/lint/suppress.py
View file @ 00de0eea
......@@ -37,13 +37,13 @@ _DOC = (
'Still reading?\n'
'- You can edit this file manually to suppress an issue\n'
' globally if it is not applicable to the project.\n'
' When inserting new tags, keep this file in sorted order.\n'
'- You can also automatically add issues found so for in the\n'
' build process by running:\n\n'
' ' + os.path.relpath(_THIS_FILE, host_paths.DIR_SOURCE_ROOT) + '\n\n'
' which will generate this file (Comments are not preserved).\n'
' Note: PRODUCT_DIR will be substituted at run-time with actual\n'
' directory path (e.g. out/Debug)\n'
)
' directory path (e.g. out/Debug)\n')
_Issue = collections.namedtuple('Issue', ['severity', 'paths', 'regexps'])
......
build/android/lint/suppressions.xml
View file @ 00de0eea
......@@ -11,7 +11,8 @@ STOP! It looks like you want to suppress some lint errors:
Still reading?
- You can edit this file manually to suppress an issue
globally if it is not applicable to the project.
globally if it is not applicable to the project. When inserting new tags,
keep this file in sorted order.
- You can also automatically add issues found so for in the
build process by running:
......@@ -32,8 +33,7 @@ Still reading?
<issue id="AuthLeak" severity="Error">
<ignore regexp="chrome/android/javatests"/>
</issue>
<issue id="BadHostnameVerifier" severity="Error">
</issue>
<issue id="BadHostnameVerifier" severity="Error"/>
<issue id="ButtonOrder" severity="Error">
<ignore regexp="chrome/android/java/res/layout/homepage_editor.xml"/>
</issue>
......@@ -59,9 +59,9 @@ Still reading?
</issue>
<!-- TODO(crbug.com/635567): Fix this properly. -->
<issue id="Deprecated" severity="Error">
<ignore regexp="android:singleLine"/>
<ignore regexp="AndroidManifest.xml"/>
<ignore regexp="/test/"/>
<ignore regexp="AndroidManifest.xml"/>
<ignore regexp="android:singleLine"/>
</issue>
<issue id="DrawAllocation">
<ignore regexp="content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java"/>
......@@ -88,9 +88,9 @@ Still reading?
<ignore regexp="AndroidManifest.xml"/>
</issue>
<issue id="HandlerLeak">
<ignore regexp="android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java" />
<ignore regexp="chromecast/internal" />
<ignore regexp="remoting/android/java/src/org/chromium/chromoting/TapGestureDetector.java" />
<ignore regexp="android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java"/>
<ignore regexp="chromecast/internal"/>
<ignore regexp="remoting/android/java/src/org/chromium/chromoting/TapGestureDetector.java"/>
</issue>
<issue id="HardcodedDebugMode" severity="Fatal">
<ignore path="AndroidManifest.xml"/>
......@@ -107,48 +107,45 @@ Still reading?
<ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xxxhdpi/notification_icon.png"/>
</issue>
<issue id="IconDensities">
<!-- This is intentional to save on WebAPKs' size. -->
<ignore regexp="chrome/android/webapk/shell_apk/res/drawable-*"/>
<!-- This is intentional to reduce APK size. See: http://crrev/c/1352161 -->
<ignore regexp="chrome/android/features/autofill_assistant/java/res/drawable-*"/>
<!-- crbug.com/457918 is tracking missing assets -->
<ignore regexp="chrome/android/java/res/drawable-xxhdpi"/>
<ignore regexp="chrome/android/java/res/drawable-xxxhdpi"/>
<!-- This is intentional to save on WebAPKs' size. -->
<ignore regexp="chrome/android/webapk/shell_apk/res/drawable-*"/>
<ignore regexp="chromecast/internal"/>
<ignore regexp="content/public/android/java/res/drawable-xxhdpi"/>
<ignore regexp="content/public/android/java/res/drawable-xxxhdpi"/>
<ignore regexp="ui/android/java/res/drawable-xxhdpi"/>
<ignore regexp="ui/android/java/res/drawable-xxxhdpi"/>
<!-- This is intentional to reduce APK size. See: http://crrev/c/1352161 -->
<ignore regexp="chrome/android/features/autofill_assistant/java/res/drawable-*"/>
</issue>
<issue id="IconDipSize">
<ignore regexp="chromecast/internal"/>
<!-- These only need to be 1px for all densities. See: crbug.com/804449 -->
<ignore regexp="chrome/android/java/res/.*tab_strip_fade"/>
<ignore regexp="chromecast/internal"/>
</issue>
<issue id="IconDuplicates" severity="Error">
<ignore regexp="chromecast/internal"/>
<!-- mipmap version is used for app launcher only. drawables used for notifications -->
<ignore regexp="chromecast/browser/android/apk/res/mipmap-.*/app_icon.png"/>
<ignore regexp="chromecast/internal"/>
</issue>
<issue id="IconDuplicatesConfig" severity="Error">
<ignore regexp="chromecast/internal"/>
</issue>
<issue id="IconLauncherFormat" severity="ignore">
<!-- TODO(crbug.com/739746): Remove after lint version has been updated. -->
<ignore regexp="remoting/android/java/res/mipmap-anydpi-v26/ic_launcher.xml"/>
</issue>
<issue id="IconLauncherFormat" severity="ignore"/>
<issue id="IconLauncherShape" severity="Error">
<ignore regexp="chromecast/internal"/>
<ignore regexp="chrome/android/webapk/shell_apk/res/mipmap-mdpi/ic_launcher_background.png"/>
<ignore regexp="chromecast/internal"/>
</issue>
<issue id="IconLocation">
<ignore regexp="chromecast/internal"/>
<!-- This is just for testing -->
<ignore regexp="chrome/test/chromedriver/test/webview_shell/java/res/drawable/icon.png"/>
<!-- Memconsumer is only for tooling -->
<ignore regexp="tools/android/memconsumer/java/res/drawable/"/>
<ignore regexp="chromecast/internal"/>
<!-- It is OK for content_shell_apk to have missing assets. -->
<ignore regexp="content/shell/android/java/res/"/>
<!-- Memconsumer is only for tooling -->
<ignore regexp="tools/android/memconsumer/java/res/drawable/"/>
</issue>
<issue id="IconMissingDensityFolder">
<!-- see crbug.com/542435 -->
......@@ -156,10 +153,10 @@ Still reading?
<ignore regexp="android_webview/tools/system_webview_shell/apk/res"/>
<ignore regexp="chrome/android/webapk/shell_apk/res"/>
<ignore regexp="chromecast/internal"/>
<ignore regexp="tools/android/push_apps_to_background/res"/>
<ignore regexp="ui/android/java/res"/>
<!-- crbug.com/457918 is tracking missing assets -->
<ignore regexp="components/embedder_support/android/java/res"/>
<ignore regexp="tools/android/push_apps_to_background/res"/>
<ignore regexp="ui/android/java/res"/>
</issue>
<issue id="ImpliedQuantity" severity="Error">
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd"/>
......@@ -179,11 +176,11 @@ Still reading?
<ignore regexp="espresso/espresso_core_java.interface.jar"/>
</issue>
<issue id="InvalidVectorPath" severity="ignore"/>
<!-- TODO(crbug.com/804453): Remove this after fixing. -->
<issue id="KeyboardInaccessibleWidget" severity="ignore"/>
<issue id="LabelFor" severity="Error">
<ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/activity_webview_browser.xml"/>
</issue>
<!-- TODO(crbug.com/804453): Remove this after fixing. -->
<issue id="KeyboardInaccessibleWidget" severity="ignore"/>
<issue id="LintError">
<!-- We no longer supply class files to lint. -->
<ignore regexp="No `.class` files were found in project"/>
......@@ -221,23 +218,24 @@ Still reading?
<ignore path="AndroidManifest.xml"/>
</issue>
<issue id="NewApi">
<!-- 1 We support try-with-resources via desugar. -->
<ignore regexp="Call requires API level 19.*`java.lang.Throwable#addSuppressed`"/>
<!-- 1 We support requireNonNull via desugar. -->
<ignore regexp="Call requires API level 19.*`java.util.Objects#requireNonNull`"/>
<!-- Do not add new suppressions without rationale. -->
<!-- 2 AutoCloseable has been available since API 15, just hidden. -->
<ignore regexp="Class requires API level 19.*java.lang.AutoCloseable"/>
<ignore regexp="Call requires API level 19.*java.lang.AutoCloseable#close"/>
<!-- 1 We support requireNonNull via desugar. -->
<ignore regexp="Call requires API level 19.*`java.util.Objects#requireNonNull`"/>
<!-- 2 We support try-with-resources via desugar. -->
<ignore regexp="Try-with-resources requires API level 19"/>
<ignore regexp="Call requires API level 19.*`java.lang.Throwable#addSuppressed`"/>
<ignore regexp="Class requires API level 19.*java.lang.AutoCloseable"/>
<!-- 1 We support default methods via desugar. -->
<ignore regexp="Default method requires API level 24"/>
<!-- 1 TaskInfo is refactored at API 29. -->
<ignore regexp="Field requires API level 29.*`android.app.TaskInfo"/>
<!-- 1 We support static interface methods via desugar. -->
<ignore regexp="Static interface method requires API level 24"/>
<!-- 1 We support try-with-resources via desugar. -->
<ignore regexp="Try-with-resources requires API level 19"/>
<!-- 1 This is for testonly target android_support_chromium_java in android_sdk. -->
<ignore regexp="third_party/android_sdk/public/extras/chromium/support/src/org/chromium/android/support/PackageManagerWrapper.java"/>
<!-- 1 TaskInfo is refactored at API 29. -->
<ignore regexp="Field requires API level 29.*`android.app.TaskInfo"/>
<!-- Endnote: Please specify number of suppressions when adding more -->
</issue>
<!-- This warning just adds a lot of false positives. -->
......@@ -247,8 +245,8 @@ Still reading?
</issue>
<issue id="Overdraw" severity="ignore"/>
<issue id="PackageManagerGetSignatures">
<ignore regexp="chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java"/>
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/browserservices/OriginVerifier.java"/>
<ignore regexp="chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java"/>
</issue>
<issue id="PluralsCandidate" severity="Error">
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-en-rGB/android_chrome_strings.xml"/>
......@@ -301,22 +299,12 @@ Still reading?
<ignore regexp="chrome/app/policy/android/values-v21/restriction_values.xml"/>
</issue>
<!-- Typos check disabled due to lint bug: http://crbug.com/671170 -->
<issue id="Typos" severity="ignore" />
<issue id="Typos" severity="ignore"/>
<!-- Our generated enums are allowed to have the same values. -->
<issue id="UniqueConstants" severity="ignore"/>
<issue id="UnusedAttribute" severity="ignore"/>
<issue id="UnusedIds" severity="ignore"/>
<issue id="UnusedQuantity" severity="Error">
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-cs/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-in/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-ja/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-ko/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-lt/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-ms/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-sk/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-th/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-vi/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-zh-rCN/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-zh-rTW/android_chrome_strings.xml"/>
<!-- This is needed for suppressing warnings on upstream and downstream build bots -->
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-cs/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-in/android_chrome_tab_ui_strings.xml"/>
......@@ -329,43 +317,28 @@ Still reading?
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-vi/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-zh-rCN/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-zh-rTW/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-cs/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-in/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-ja/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-ko/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-lt/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-ms/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-sk/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-th/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-vi/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-zh-rCN/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-zh-rTW/android_chrome_strings.xml"/>
</issue>
<!-- Our generated enums are allowed to have the same values. -->
<issue id="UniqueConstants" severity="ignore"/>
<issue id="UnusedResources">
<!-- Do not add new suppressions without rationale. -->
<!-- crbug.com/1004570 remove this line and the following three lines after the bug resolved -->
<ignore regexp="The resource `R.string.tab_suggestion_review_button` appears to be unused"/>
<ignore regexp="The resource `R.string.tab_suggestion_close_tab_action_button` appears to be unused"/>
<ignore regexp="The resource `R.string.tab_suggestion_close_stale_message` appears to be unused"/>
<!-- crbug.com/1017492 remove this line and the following line after the bug is resolved -->
<ignore regexp="The resource `R.string.tab_grid_dialog_toolbar_share_group` appears to be unused"/>
<!-- 3 raw resources are accessed by URL in various places -->
<ignore regexp="PRODUCT_DIR/gen/remoting/android/.*/res/raw/credits.html"/>
<ignore regexp="PRODUCT_DIR/gen/remoting/android/.*/res/raw/credits_css.css"/>
<ignore regexp="PRODUCT_DIR/gen/remoting/android/.*/res/raw/credits_js.js"/>
<!-- 1 string test only, used in CronetSmokeTestCase dynamically -->
<ignore regexp="R.string.TestSupportImplClass"/>
<!-- 1 string used by Android's policies system, pulled from app directly -->
<ignore regexp="restriction_values.xml"/>
<!-- 3 resources test only, used in webview tests dynamically -->
<ignore regexp="android_webview/tools/automated_ui_tests/java/res/layout/"/>
<ignore regexp="android_webview/test/shell/res/raw/resource_file.html"/>
<ignore regexp="android_webview/test/shell/res/raw/resource_icon.png"/>
<!-- 2 resources used by android webview glue layer, could be refactored -->
<ignore regexp="android_webview/java/res/drawable-hdpi/ic_play_circle_outline_black_48dp.png"/>
<!-- 1 resource used by android webview glue layer, could be refactored -->
<ignore regexp="R.string.private_browsing_warning"/>
<!-- 2 resource sets used by clank widgets for each channel -->
<ignore regexp="The resource `R.string.bookmark_widget_title.*` appears to be unused"/>
<ignore regexp="The resource `R.string.search_widget_title.*` appears to be unused"/>
<!-- 1 resource used by android tv to generate resources.zip file -->
<ignore regexp="chromecast/internal/shell/browser/android/java/res/drawable-hdpi/ic_settings_cast.png"/>
<!-- Module titles may only be used by the Play Store. -->
<ignore regexp="The resource `R.string.*_module_title` appears to be unused"/>
<!-- Old-style and new-style WebAPKs use same resources for simplicity. Old-style WebAPKs do
not use R.style.SplashTheme but new-style WebAPKs do.
TODO(crbug.com/971254): Remove suppression once old-style WebAPKs are deprecated. -->
<ignore regexp="The resource `R.style.SplashTheme` appears to be unused"/>
<!-- The WAM server currently has 2 codes paths for minting a WebAPK, and
it needs these "unused" resources.
TODO(crbug.com/1001115): Remove suppression once 2 code paths are merged -->
......@@ -373,15 +346,42 @@ Still reading?
<ignore regexp="The resource `R.mipmap.ic_launcher_foreground` appears to be unused"/>
<ignore regexp="The resource `R.mipmap.maskable_splash_icon_xxhdpi` appears to be unused"/>
<ignore regexp="The resource `R.mipmap.maskable_splash_icon_xxxhdpi` appears to be unused"/>
<!-- Module titles may only be used by the Play Store. -->
<ignore regexp="The resource `R.string.*_module_title` appears to be unused"/>
<!-- 2 resource sets used by clank widgets for each channel -->
<ignore regexp="The resource `R.string.bookmark_widget_title.*` appears to be unused"/>
<ignore regexp="The resource `R.string.search_widget_title.*` appears to be unused"/>
<!-- crbug.com/1017492 remove this line and the following line after the bug is resolved -->
<ignore regexp="The resource `R.string.tab_grid_dialog_toolbar_share_group` appears to be unused"/>
<!-- crbug.com/1004570 remove this line and the following three lines after the bug resolved -->
<ignore regexp="The resource `R.string.tab_suggestion_close_stale_message` appears to be unused"/>
<ignore regexp="The resource `R.string.tab_suggestion_close_tab_action_button` appears to be unused"/>
<ignore regexp="The resource `R.string.tab_suggestion_review_button` appears to be unused"/>
<!-- Old-style and new-style WebAPKs use same resources for simplicity. Old-style WebAPKs do
not use R.style.SplashTheme but new-style WebAPKs do.
TODO(crbug.com/971254): Remove suppression once old-style WebAPKs are deprecated. -->
<ignore regexp="The resource `R.style.SplashTheme` appears to be unused"/>
<!-- 1 resource used by android webview glue layer, could be refactored -->
<ignore regexp="android_webview/java/res/drawable-hdpi/ic_play_circle_outline_black_48dp.png"/>
<!-- 3 resources test only, used in webview tests dynamically -->
<ignore regexp="android_webview/test/shell/res/raw/resource_file.html"/>
<ignore regexp="android_webview/test/shell/res/raw/resource_icon.png"/>
<ignore regexp="android_webview/tools/automated_ui_tests/java/res/layout/"/>
<!-- TODO(https://crbug.com/1017190): Remove suppression once we lint entire app rather than
each individual target -->
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd" />
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd"/>
<!-- 1 resource used by android tv to generate resources.zip file -->
<ignore regexp="chromecast/internal/shell/browser/android/java/res/drawable-hdpi/ic_settings_cast.png"/>
<!-- 1 string used by Android's policies system, pulled from app directly -->
<ignore regexp="restriction_values.xml"/>
<!-- Endnote: Please specify number of suppressions when adding more -->
</issue>
<issue id="UseCompoundDrawables">
<!-- Upscaling 24dp to 48dp doesn't work as expected with a TextView compound drawable. -->
<ignore regexp="chrome/android/java/res/layout/photo_picker_bitmap_view.xml"/>
</issue>
<!-- TODO(crbug.com/807734): Investigate and possible remove this -->
<issue id="UseSparseArrays" severity="ignore"/>
<issue id="UselessParent">
<ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/activity_webview_browser.xml"/>
<ignore regexp="chrome/android/java/res/layout/data_usage_breakdown.xml"/>
......@@ -391,8 +391,6 @@ Still reading?
<issue id="UsesMinSdkAttributes" severity="Error">
<ignore regexp="AndroidManifest.xml"/>
</issue>
<!-- TODO(crbug.com/807734): Investigate and possible remove this -->
<issue id="UseSparseArrays" severity="ignore"/>
<issue id="ValidFragment" severity="Error">
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/router/BaseMediaRouteDialogManager.java"/>
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteChooserDialogManager.java"/>
......@@ -414,9 +412,9 @@ Still reading?
</issue>
<issue id="WrongCall" severity="ignore"/>
<issue id="WrongConstant">
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClientCertificateRequest.java"/>
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java"/>
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java"/>
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClientCertificateRequest.java"/>
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorDialog.java"/>
<ignore regexp="third_party/android_data_chart/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java"/>
</issue>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment