Commit 01561548 authored by tzik's avatar tzik Committed by Commit Bot

Rewrite base::Bind to base::BindOnce in chrome/browser/media/router

This is a generated CL to rewrite base::Bind to base::BindOnce where
the result of base::Bind is immediately converted to OnceCallback.
E.g.:
  base::PostTask(FROM_HERE, base::Bind(&Foo));
is rewritten to:
  base::PostTask(FROM_HERE, base::BindOnce(&Foo));

An explainer of OnceCallback is available here goo.gl/YZiUL1.

The rewriting tool is in //tools/clang/base_bind_rewriters. To build and
run locally, follow //docs/clang_tool_refactoring.md.

This conversion makes almost no behavior change except that a bound
objects are passed-by-move to the target function.

Bug: 554299, 714018
Change-Id: Ief819fd7850d61a377300d61fd5a317104084c77
Reviewed-on: https://chromium-review.googlesource.com/547179Reviewed-by: default avatarmark a. foltz <mfoltz@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485892}
parent 50255df1
...@@ -62,8 +62,8 @@ void BrowserPresentationConnectionProxy::OnMessagesReceived( ...@@ -62,8 +62,8 @@ void BrowserPresentationConnectionProxy::OnMessagesReceived(
// TODO(imcheng): It would be slightly more efficient to send messages in // TODO(imcheng): It would be slightly more efficient to send messages in
// a single batch. // a single batch.
for (const auto& message : messages) { for (const auto& message : messages) {
target_connection_ptr_->OnMessage(message, target_connection_ptr_->OnMessage(
base::Bind(&OnMessageReceivedByRenderer)); message, base::BindOnce(&OnMessageReceivedByRenderer));
} }
} }
} // namespace media_router } // namespace media_router
...@@ -70,9 +70,9 @@ TEST_F(CreatePresentationConnectionRequestTest, Getters) { ...@@ -70,9 +70,9 @@ TEST_F(CreatePresentationConnectionRequestTest, Getters) {
"Unknown error."); "Unknown error.");
CreatePresentationConnectionRequest request( CreatePresentationConnectionRequest request(
render_frame_host_id_, presentation_urls_, url::Origin(GURL(kFrameUrl)), render_frame_host_id_, presentation_urls_, url::Origin(GURL(kFrameUrl)),
base::Bind(&CreatePresentationConnectionRequestTest::FailOnSuccess, base::BindOnce(&CreatePresentationConnectionRequestTest::FailOnSuccess,
base::Unretained(this)), base::Unretained(this)),
base::Bind(&CreatePresentationConnectionRequestTest::OnError, base::BindOnce(&CreatePresentationConnectionRequestTest::OnError,
base::Unretained(this), error)); base::Unretained(this), error));
PresentationRequest presentation_request( PresentationRequest presentation_request(
...@@ -87,9 +87,9 @@ TEST_F(CreatePresentationConnectionRequestTest, SuccessCallback) { ...@@ -87,9 +87,9 @@ TEST_F(CreatePresentationConnectionRequestTest, SuccessCallback) {
kPresentationId); kPresentationId);
CreatePresentationConnectionRequest request( CreatePresentationConnectionRequest request(
render_frame_host_id_, {presentation_url_}, url::Origin(GURL(kFrameUrl)), render_frame_host_id_, {presentation_url_}, url::Origin(GURL(kFrameUrl)),
base::Bind(&CreatePresentationConnectionRequestTest::OnSuccess, base::BindOnce(&CreatePresentationConnectionRequestTest::OnSuccess,
base::Unretained(this), presentation_info), base::Unretained(this), presentation_info),
base::Bind(&CreatePresentationConnectionRequestTest::FailOnError, base::BindOnce(&CreatePresentationConnectionRequestTest::FailOnError,
base::Unretained(this))); base::Unretained(this)));
MediaRoute route(kRouteId, MediaSourceForTab(1), "sinkId", "Description", MediaRoute route(kRouteId, MediaSourceForTab(1), "sinkId", "Description",
false, "", false); false, "", false);
...@@ -103,9 +103,9 @@ TEST_F(CreatePresentationConnectionRequestTest, ErrorCallback) { ...@@ -103,9 +103,9 @@ TEST_F(CreatePresentationConnectionRequestTest, ErrorCallback) {
"This is an error message"); "This is an error message");
CreatePresentationConnectionRequest request( CreatePresentationConnectionRequest request(
render_frame_host_id_, presentation_urls_, url::Origin(GURL(kFrameUrl)), render_frame_host_id_, presentation_urls_, url::Origin(GURL(kFrameUrl)),
base::Bind(&CreatePresentationConnectionRequestTest::FailOnSuccess, base::BindOnce(&CreatePresentationConnectionRequestTest::FailOnSuccess,
base::Unretained(this)), base::Unretained(this)),
base::Bind(&CreatePresentationConnectionRequestTest::OnError, base::BindOnce(&CreatePresentationConnectionRequestTest::OnError,
base::Unretained(this), error)); base::Unretained(this), error));
request.InvokeErrorCallback(error); request.InvokeErrorCallback(error);
EXPECT_TRUE(cb_invoked_); EXPECT_TRUE(cb_invoked_);
......
...@@ -28,7 +28,7 @@ void DialMediaSinkServiceProxy::Start() { ...@@ -28,7 +28,7 @@ void DialMediaSinkServiceProxy::Start() {
content::BrowserThread::PostTask( content::BrowserThread::PostTask(
content::BrowserThread::IO, FROM_HERE, content::BrowserThread::IO, FROM_HERE,
base::Bind(&DialMediaSinkServiceProxy::StartOnIOThread, this)); base::BindOnce(&DialMediaSinkServiceProxy::StartOnIOThread, this));
} }
void DialMediaSinkServiceProxy::Stop() { void DialMediaSinkServiceProxy::Stop() {
...@@ -36,7 +36,7 @@ void DialMediaSinkServiceProxy::Stop() { ...@@ -36,7 +36,7 @@ void DialMediaSinkServiceProxy::Stop() {
content::BrowserThread::PostTask( content::BrowserThread::PostTask(
content::BrowserThread::IO, FROM_HERE, content::BrowserThread::IO, FROM_HERE,
base::Bind(&DialMediaSinkServiceProxy::StopOnIOThread, this)); base::BindOnce(&DialMediaSinkServiceProxy::StopOnIOThread, this));
} }
void DialMediaSinkServiceProxy::SetDialMediaSinkServiceForTest( void DialMediaSinkServiceProxy::SetDialMediaSinkServiceForTest(
...@@ -72,7 +72,7 @@ void DialMediaSinkServiceProxy::OnSinksDiscoveredOnIOThread( ...@@ -72,7 +72,7 @@ void DialMediaSinkServiceProxy::OnSinksDiscoveredOnIOThread(
DCHECK_CURRENTLY_ON(BrowserThread::IO); DCHECK_CURRENTLY_ON(BrowserThread::IO);
content::BrowserThread::PostTask( content::BrowserThread::PostTask(
content::BrowserThread::UI, FROM_HERE, content::BrowserThread::UI, FROM_HERE,
base::Bind(sink_discovery_callback_, std::move(sinks))); base::BindOnce(sink_discovery_callback_, std::move(sinks)));
} }
} // namespace media_router } // namespace media_router
...@@ -107,7 +107,7 @@ void DiscoveryNetworkMonitor::OnNetworkChanged( ...@@ -107,7 +107,7 @@ void DiscoveryNetworkMonitor::OnNetworkChanged(
net::NetworkChangeNotifier::ConnectionType) { net::NetworkChangeNotifier::ConnectionType) {
BrowserThread::PostTask( BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE, BrowserThread::IO, FROM_HERE,
base::Bind(&DiscoveryNetworkMonitor::UpdateNetworkInfo, base::BindOnce(&DiscoveryNetworkMonitor::UpdateNetworkInfo,
base::Unretained(this))); base::Unretained(this)));
} }
......
...@@ -70,9 +70,9 @@ class MediaRouterDialogControllerTest : public ChromeRenderViewHostTestHarness { ...@@ -70,9 +70,9 @@ class MediaRouterDialogControllerTest : public ChromeRenderViewHostTestHarness {
RenderFrameHostId(1, 2), RenderFrameHostId(1, 2),
{GURL("http://example.com"), GURL("http://example2.com")}, {GURL("http://example.com"), GURL("http://example2.com")},
url::Origin(GURL("http://google.com")), url::Origin(GURL("http://google.com")),
base::Bind(&MediaRouterDialogControllerTest::RequestSuccess, base::BindOnce(&MediaRouterDialogControllerTest::RequestSuccess,
base::Unretained(this)), base::Unretained(this)),
base::Bind(&MediaRouterDialogControllerTest::RequestError, base::BindOnce(&MediaRouterDialogControllerTest::RequestError,
base::Unretained(this)))); base::Unretained(this))));
} }
......
...@@ -38,7 +38,7 @@ MediaRouteController::MediaRouteController( ...@@ -38,7 +38,7 @@ MediaRouteController::MediaRouteController(
binding_(this) { binding_(this) {
DCHECK(mojo_media_controller_.is_bound()); DCHECK(mojo_media_controller_.is_bound());
DCHECK(media_router); DCHECK(media_router);
mojo_media_controller_.set_connection_error_handler(base::Bind( mojo_media_controller_.set_connection_error_handler(base::BindOnce(
&MediaRouteController::OnMojoConnectionError, base::Unretained(this))); &MediaRouteController::OnMojoConnectionError, base::Unretained(this)));
} }
...@@ -88,7 +88,7 @@ mojom::MediaStatusObserverPtr MediaRouteController::BindObserverPtr() { ...@@ -88,7 +88,7 @@ mojom::MediaStatusObserverPtr MediaRouteController::BindObserverPtr() {
DCHECK(!binding_.is_bound()); DCHECK(!binding_.is_bound());
mojom::MediaStatusObserverPtr observer; mojom::MediaStatusObserverPtr observer;
binding_.Bind(mojo::MakeRequest(&observer)); binding_.Bind(mojo::MakeRequest(&observer));
binding_.set_connection_error_handler(base::Bind( binding_.set_connection_error_handler(base::BindOnce(
&MediaRouteController::OnMojoConnectionError, base::Unretained(this))); &MediaRouteController::OnMojoConnectionError, base::Unretained(this)));
return observer; return observer;
} }
......
...@@ -108,7 +108,7 @@ void MediaRouterMojoImpl::BindToMojoRequest( ...@@ -108,7 +108,7 @@ void MediaRouterMojoImpl::BindToMojoRequest(
binding_ = base::MakeUnique<mojo::Binding<mojom::MediaRouter>>( binding_ = base::MakeUnique<mojo::Binding<mojom::MediaRouter>>(
this, std::move(request)); this, std::move(request));
binding_->set_connection_error_handler(base::Bind( binding_->set_connection_error_handler(base::BindOnce(
&MediaRouterMojoImpl::OnConnectionError, base::Unretained(this))); &MediaRouterMojoImpl::OnConnectionError, base::Unretained(this)));
event_page_request_manager_->SetExtensionId(extension.id()); event_page_request_manager_->SetExtensionId(extension.id());
...@@ -140,7 +140,7 @@ void MediaRouterMojoImpl::RegisterMediaRouteProvider( ...@@ -140,7 +140,7 @@ void MediaRouterMojoImpl::RegisterMediaRouteProvider(
#endif #endif
media_route_provider_ = std::move(media_route_provider_ptr); media_route_provider_ = std::move(media_route_provider_ptr);
media_route_provider_.set_connection_error_handler(base::Bind( media_route_provider_.set_connection_error_handler(base::BindOnce(
&MediaRouterMojoImpl::OnConnectionError, base::Unretained(this))); &MediaRouterMojoImpl::OnConnectionError, base::Unretained(this)));
auto config = mojom::MediaRouteProviderConfig::New(); auto config = mojom::MediaRouteProviderConfig::New();
...@@ -429,8 +429,9 @@ void MediaRouterMojoImpl::ProvideSinks(const std::string& provider_name, ...@@ -429,8 +429,9 @@ void MediaRouterMojoImpl::ProvideSinks(const std::string& provider_name,
<< sinks.size() << " devices..."; << sinks.size() << " devices...";
event_page_request_manager_->RunOrDefer( event_page_request_manager_->RunOrDefer(
base::Bind(&MediaRouterMojoImpl::DoProvideSinks, base::BindOnce(&MediaRouterMojoImpl::DoProvideSinks,
weak_factory_.GetWeakPtr(), provider_name, std::move(sinks)), weak_factory_.GetWeakPtr(), provider_name,
std::move(sinks)),
MediaRouteProviderWakeReason::PROVIDE_SINKS); MediaRouteProviderWakeReason::PROVIDE_SINKS);
} }
...@@ -604,7 +605,7 @@ void MediaRouterMojoImpl::RegisterRouteMessageObserver( ...@@ -604,7 +605,7 @@ void MediaRouterMojoImpl::RegisterRouteMessageObserver(
observer_list->AddObserver(observer); observer_list->AddObserver(observer);
if (should_listen) { if (should_listen) {
event_page_request_manager_->RunOrDefer( event_page_request_manager_->RunOrDefer(
base::Bind(&MediaRouterMojoImpl::DoStartListeningForRouteMessages, base::BindOnce(&MediaRouterMojoImpl::DoStartListeningForRouteMessages,
weak_factory_.GetWeakPtr(), route_id), weak_factory_.GetWeakPtr(), route_id),
MediaRouteProviderWakeReason::START_LISTENING_FOR_ROUTE_MESSAGES); MediaRouteProviderWakeReason::START_LISTENING_FOR_ROUTE_MESSAGES);
} }
...@@ -651,7 +652,7 @@ void MediaRouterMojoImpl::DoCreateRoute( ...@@ -651,7 +652,7 @@ void MediaRouterMojoImpl::DoCreateRoute(
<< ", presentation ID: " << presentation_id; << ", presentation ID: " << presentation_id;
media_route_provider_->CreateRoute( media_route_provider_->CreateRoute(
source_id, sink_id, presentation_id, origin, tab_id, timeout, incognito, source_id, sink_id, presentation_id, origin, tab_id, timeout, incognito,
base::Bind(&MediaRouterMojoImpl::RouteResponseReceived, base::BindOnce(&MediaRouterMojoImpl::RouteResponseReceived,
base::Unretained(this), presentation_id, incognito, base::Unretained(this), presentation_id, incognito,
base::Passed(&callbacks), false)); base::Passed(&callbacks), false));
} }
...@@ -669,7 +670,7 @@ void MediaRouterMojoImpl::DoJoinRoute( ...@@ -669,7 +670,7 @@ void MediaRouterMojoImpl::DoJoinRoute(
media_route_provider_->JoinRoute( media_route_provider_->JoinRoute(
source_id, presentation_id, origin, tab_id, timeout, incognito, source_id, presentation_id, origin, tab_id, timeout, incognito,
base::Bind(&MediaRouterMojoImpl::RouteResponseReceived, base::BindOnce(&MediaRouterMojoImpl::RouteResponseReceived,
base::Unretained(this), presentation_id, incognito, base::Unretained(this), presentation_id, incognito,
base::Passed(&callbacks), true)); base::Passed(&callbacks), true));
} }
...@@ -689,7 +690,7 @@ void MediaRouterMojoImpl::DoConnectRouteByRouteId( ...@@ -689,7 +690,7 @@ void MediaRouterMojoImpl::DoConnectRouteByRouteId(
media_route_provider_->ConnectRouteByRouteId( media_route_provider_->ConnectRouteByRouteId(
source_id, route_id, presentation_id, origin, tab_id, timeout, incognito, source_id, route_id, presentation_id, origin, tab_id, timeout, incognito,
base::Bind(&MediaRouterMojoImpl::RouteResponseReceived, base::BindOnce(&MediaRouterMojoImpl::RouteResponseReceived,
base::Unretained(this), presentation_id, incognito, base::Unretained(this), presentation_id, incognito,
base::Passed(&callbacks), true)); base::Passed(&callbacks), true));
} }
...@@ -697,8 +698,7 @@ void MediaRouterMojoImpl::DoConnectRouteByRouteId( ...@@ -697,8 +698,7 @@ void MediaRouterMojoImpl::DoConnectRouteByRouteId(
void MediaRouterMojoImpl::DoTerminateRoute(const MediaRoute::Id& route_id) { void MediaRouterMojoImpl::DoTerminateRoute(const MediaRoute::Id& route_id) {
DVLOG_WITH_INSTANCE(1) << "DoTerminateRoute " << route_id; DVLOG_WITH_INSTANCE(1) << "DoTerminateRoute " << route_id;
media_route_provider_->TerminateRoute( media_route_provider_->TerminateRoute(
route_id, route_id, base::BindOnce(&MediaRouterMojoImpl::OnTerminateRouteResult,
base::Bind(&MediaRouterMojoImpl::OnTerminateRouteResult,
base::Unretained(this), route_id)); base::Unretained(this), route_id));
} }
...@@ -769,7 +769,7 @@ void MediaRouterMojoImpl::DoCreateMediaRouteController( ...@@ -769,7 +769,7 @@ void MediaRouterMojoImpl::DoCreateMediaRouteController(
media_route_provider_->CreateMediaRouteController( media_route_provider_->CreateMediaRouteController(
route_id, std::move(mojo_media_controller_request), route_id, std::move(mojo_media_controller_request),
std::move(mojo_observer), std::move(mojo_observer),
base::Bind(&MediaRouterMojoImpl::OnMediaControllerCreated, base::BindOnce(&MediaRouterMojoImpl::OnMediaControllerCreated,
base::Unretained(this), route_id)); base::Unretained(this), route_id));
} }
......
...@@ -230,7 +230,7 @@ TEST_F(MediaRouterMojoImplTest, CreateRoute) { ...@@ -230,7 +230,7 @@ TEST_F(MediaRouterMojoImplTest, CreateRoute) {
RouteRequestResult::OK)) RouteRequestResult::OK))
.WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); })); .WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); }));
std::vector<MediaRouteResponseCallback> route_response_callbacks; std::vector<MediaRouteResponseCallback> route_response_callbacks;
route_response_callbacks.push_back(base::Bind( route_response_callbacks.push_back(base::BindOnce(
&RouteResponseCallbackHandler::Invoke, base::Unretained(&handler))); &RouteResponseCallbackHandler::Invoke, base::Unretained(&handler)));
router()->CreateRoute(kSource, kSinkId, url::Origin(GURL(kOrigin)), nullptr, router()->CreateRoute(kSource, kSinkId, url::Origin(GURL(kOrigin)), nullptr,
std::move(route_response_callbacks), std::move(route_response_callbacks),
...@@ -269,7 +269,7 @@ TEST_F(MediaRouterMojoImplTest, CreateIncognitoRoute) { ...@@ -269,7 +269,7 @@ TEST_F(MediaRouterMojoImplTest, CreateIncognitoRoute) {
RouteRequestResult::OK)) RouteRequestResult::OK))
.WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); })); .WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); }));
std::vector<MediaRouteResponseCallback> route_response_callbacks; std::vector<MediaRouteResponseCallback> route_response_callbacks;
route_response_callbacks.push_back(base::Bind( route_response_callbacks.push_back(base::BindOnce(
&RouteResponseCallbackHandler::Invoke, base::Unretained(&handler))); &RouteResponseCallbackHandler::Invoke, base::Unretained(&handler)));
router()->CreateRoute(kSource, kSinkId, url::Origin(GURL(kOrigin)), nullptr, router()->CreateRoute(kSource, kSinkId, url::Origin(GURL(kOrigin)), nullptr,
std::move(route_response_callbacks), std::move(route_response_callbacks),
...@@ -300,7 +300,7 @@ TEST_F(MediaRouterMojoImplTest, CreateRouteFails) { ...@@ -300,7 +300,7 @@ TEST_F(MediaRouterMojoImplTest, CreateRouteFails) {
DoInvoke(nullptr, "", kError, RouteRequestResult::TIMED_OUT)) DoInvoke(nullptr, "", kError, RouteRequestResult::TIMED_OUT))
.WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); })); .WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); }));
std::vector<MediaRouteResponseCallback> route_response_callbacks; std::vector<MediaRouteResponseCallback> route_response_callbacks;
route_response_callbacks.push_back(base::Bind( route_response_callbacks.push_back(base::BindOnce(
&RouteResponseCallbackHandler::Invoke, base::Unretained(&handler))); &RouteResponseCallbackHandler::Invoke, base::Unretained(&handler)));
router()->CreateRoute(kSource, kSinkId, url::Origin(GURL(kOrigin)), nullptr, router()->CreateRoute(kSource, kSinkId, url::Origin(GURL(kOrigin)), nullptr,
std::move(route_response_callbacks), std::move(route_response_callbacks),
...@@ -332,7 +332,7 @@ TEST_F(MediaRouterMojoImplTest, CreateRouteIncognitoMismatchFails) { ...@@ -332,7 +332,7 @@ TEST_F(MediaRouterMojoImplTest, CreateRouteIncognitoMismatchFails) {
RouteRequestResult::INCOGNITO_MISMATCH)) RouteRequestResult::INCOGNITO_MISMATCH))
.WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); })); .WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); }));
std::vector<MediaRouteResponseCallback> route_response_callbacks; std::vector<MediaRouteResponseCallback> route_response_callbacks;
route_response_callbacks.push_back(base::Bind( route_response_callbacks.push_back(base::BindOnce(
&RouteResponseCallbackHandler::Invoke, base::Unretained(&handler))); &RouteResponseCallbackHandler::Invoke, base::Unretained(&handler)));
router()->CreateRoute(kSource, kSinkId, url::Origin(GURL(kOrigin)), nullptr, router()->CreateRoute(kSource, kSinkId, url::Origin(GURL(kOrigin)), nullptr,
std::move(route_response_callbacks), std::move(route_response_callbacks),
...@@ -421,7 +421,7 @@ TEST_F(MediaRouterMojoImplTest, JoinRoute) { ...@@ -421,7 +421,7 @@ TEST_F(MediaRouterMojoImplTest, JoinRoute) {
RouteRequestResult::OK)) RouteRequestResult::OK))
.WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); })); .WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); }));
std::vector<MediaRouteResponseCallback> route_response_callbacks; std::vector<MediaRouteResponseCallback> route_response_callbacks;
route_response_callbacks.push_back(base::Bind( route_response_callbacks.push_back(base::BindOnce(
&RouteResponseCallbackHandler::Invoke, base::Unretained(&handler))); &RouteResponseCallbackHandler::Invoke, base::Unretained(&handler)));
router()->JoinRoute(kSource, kPresentationId, url::Origin(GURL(kOrigin)), router()->JoinRoute(kSource, kPresentationId, url::Origin(GURL(kOrigin)),
nullptr, std::move(route_response_callbacks), nullptr, std::move(route_response_callbacks),
...@@ -437,7 +437,7 @@ TEST_F(MediaRouterMojoImplTest, JoinRouteNotFoundFails) { ...@@ -437,7 +437,7 @@ TEST_F(MediaRouterMojoImplTest, JoinRouteNotFoundFails) {
RouteRequestResult::ROUTE_NOT_FOUND)) RouteRequestResult::ROUTE_NOT_FOUND))
.WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); })); .WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); }));
std::vector<MediaRouteResponseCallback> route_response_callbacks; std::vector<MediaRouteResponseCallback> route_response_callbacks;
route_response_callbacks.push_back(base::Bind( route_response_callbacks.push_back(base::BindOnce(
&RouteResponseCallbackHandler::Invoke, base::Unretained(&handler))); &RouteResponseCallbackHandler::Invoke, base::Unretained(&handler)));
router()->JoinRoute(kSource, kPresentationId, url::Origin(GURL(kOrigin)), router()->JoinRoute(kSource, kPresentationId, url::Origin(GURL(kOrigin)),
nullptr, std::move(route_response_callbacks), nullptr, std::move(route_response_callbacks),
...@@ -473,7 +473,7 @@ TEST_F(MediaRouterMojoImplTest, JoinRouteTimedOutFails) { ...@@ -473,7 +473,7 @@ TEST_F(MediaRouterMojoImplTest, JoinRouteTimedOutFails) {
DoInvoke(nullptr, "", kError, RouteRequestResult::TIMED_OUT)) DoInvoke(nullptr, "", kError, RouteRequestResult::TIMED_OUT))
.WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); })); .WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); }));
std::vector<MediaRouteResponseCallback> route_response_callbacks; std::vector<MediaRouteResponseCallback> route_response_callbacks;
route_response_callbacks.push_back(base::Bind( route_response_callbacks.push_back(base::BindOnce(
&RouteResponseCallbackHandler::Invoke, base::Unretained(&handler))); &RouteResponseCallbackHandler::Invoke, base::Unretained(&handler)));
router()->JoinRoute(kSource, kPresentationId, url::Origin(GURL(kOrigin)), router()->JoinRoute(kSource, kPresentationId, url::Origin(GURL(kOrigin)),
nullptr, std::move(route_response_callbacks), nullptr, std::move(route_response_callbacks),
...@@ -516,7 +516,7 @@ TEST_F(MediaRouterMojoImplTest, JoinRouteIncognitoMismatchFails) { ...@@ -516,7 +516,7 @@ TEST_F(MediaRouterMojoImplTest, JoinRouteIncognitoMismatchFails) {
RouteRequestResult::INCOGNITO_MISMATCH)) RouteRequestResult::INCOGNITO_MISMATCH))
.WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); })); .WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); }));
std::vector<MediaRouteResponseCallback> route_response_callbacks; std::vector<MediaRouteResponseCallback> route_response_callbacks;
route_response_callbacks.push_back(base::Bind( route_response_callbacks.push_back(base::BindOnce(
&RouteResponseCallbackHandler::Invoke, base::Unretained(&handler))); &RouteResponseCallbackHandler::Invoke, base::Unretained(&handler)));
router()->JoinRoute(kSource, kPresentationId, url::Origin(GURL(kOrigin)), router()->JoinRoute(kSource, kPresentationId, url::Origin(GURL(kOrigin)),
nullptr, std::move(route_response_callbacks), nullptr, std::move(route_response_callbacks),
...@@ -556,7 +556,7 @@ TEST_F(MediaRouterMojoImplTest, ConnectRouteByRouteId) { ...@@ -556,7 +556,7 @@ TEST_F(MediaRouterMojoImplTest, ConnectRouteByRouteId) {
RouteRequestResult::OK)) RouteRequestResult::OK))
.WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); })); .WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); }));
std::vector<MediaRouteResponseCallback> route_response_callbacks; std::vector<MediaRouteResponseCallback> route_response_callbacks;
route_response_callbacks.push_back(base::Bind( route_response_callbacks.push_back(base::BindOnce(
&RouteResponseCallbackHandler::Invoke, base::Unretained(&handler))); &RouteResponseCallbackHandler::Invoke, base::Unretained(&handler)));
router()->ConnectRouteByRouteId( router()->ConnectRouteByRouteId(
kSource, kRouteId, url::Origin(GURL(kOrigin)), nullptr, kSource, kRouteId, url::Origin(GURL(kOrigin)), nullptr,
...@@ -587,7 +587,7 @@ TEST_F(MediaRouterMojoImplTest, ConnectRouteByRouteIdFails) { ...@@ -587,7 +587,7 @@ TEST_F(MediaRouterMojoImplTest, ConnectRouteByRouteIdFails) {
DoInvoke(nullptr, "", kError, RouteRequestResult::TIMED_OUT)) DoInvoke(nullptr, "", kError, RouteRequestResult::TIMED_OUT))
.WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); })); .WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); }));
std::vector<MediaRouteResponseCallback> route_response_callbacks; std::vector<MediaRouteResponseCallback> route_response_callbacks;
route_response_callbacks.push_back(base::Bind( route_response_callbacks.push_back(base::BindOnce(
&RouteResponseCallbackHandler::Invoke, base::Unretained(&handler))); &RouteResponseCallbackHandler::Invoke, base::Unretained(&handler)));
router()->ConnectRouteByRouteId( router()->ConnectRouteByRouteId(
kSource, kRouteId, url::Origin(GURL(kOrigin)), nullptr, kSource, kRouteId, url::Origin(GURL(kOrigin)), nullptr,
...@@ -624,7 +624,7 @@ TEST_F(MediaRouterMojoImplTest, ConnectRouteByIdIncognitoMismatchFails) { ...@@ -624,7 +624,7 @@ TEST_F(MediaRouterMojoImplTest, ConnectRouteByIdIncognitoMismatchFails) {
RouteRequestResult::INCOGNITO_MISMATCH)) RouteRequestResult::INCOGNITO_MISMATCH))
.WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); })); .WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); }));
std::vector<MediaRouteResponseCallback> route_response_callbacks; std::vector<MediaRouteResponseCallback> route_response_callbacks;
route_response_callbacks.push_back(base::Bind( route_response_callbacks.push_back(base::BindOnce(
&RouteResponseCallbackHandler::Invoke, base::Unretained(&handler))); &RouteResponseCallbackHandler::Invoke, base::Unretained(&handler)));
router()->ConnectRouteByRouteId( router()->ConnectRouteByRouteId(
kSource, kRouteId, url::Origin(GURL(kOrigin)), nullptr, kSource, kRouteId, url::Origin(GURL(kOrigin)), nullptr,
...@@ -978,7 +978,7 @@ TEST_F(MediaRouterMojoImplTest, SendRouteMessage) { ...@@ -978,7 +978,7 @@ TEST_F(MediaRouterMojoImplTest, SendRouteMessage) {
EXPECT_CALL(handler, Invoke(true)) EXPECT_CALL(handler, Invoke(true))
.WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); })); .WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); }));
router()->SendRouteMessage(kRouteId, kMessage, router()->SendRouteMessage(kRouteId, kMessage,
base::Bind(&SendMessageCallbackHandler::Invoke, base::BindOnce(&SendMessageCallbackHandler::Invoke,
base::Unretained(&handler))); base::Unretained(&handler)));
run_loop.Run(); run_loop.Run();
} }
...@@ -1002,7 +1002,7 @@ TEST_F(MediaRouterMojoImplTest, SendRouteBinaryMessage) { ...@@ -1002,7 +1002,7 @@ TEST_F(MediaRouterMojoImplTest, SendRouteBinaryMessage) {
.WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); })); .WillOnce(InvokeWithoutArgs([&run_loop]() { run_loop.Quit(); }));
router()->SendRouteBinaryMessage( router()->SendRouteBinaryMessage(
kRouteId, std::move(expected_binary_data), kRouteId, std::move(expected_binary_data),
base::Bind(&SendMessageCallbackHandler::Invoke, base::BindOnce(&SendMessageCallbackHandler::Invoke,
base::Unretained(&handler))); base::Unretained(&handler)));
run_loop.Run(); run_loop.Run();
} }
...@@ -1211,7 +1211,7 @@ TEST_F(MediaRouterMojoImplTest, SearchSinks) { ...@@ -1211,7 +1211,7 @@ TEST_F(MediaRouterMojoImplTest, SearchSinks) {
SinkResponseCallbackHandler sink_handler; SinkResponseCallbackHandler sink_handler;
EXPECT_CALL(sink_handler, Invoke(kSinkId2)).Times(1); EXPECT_CALL(sink_handler, Invoke(kSinkId2)).Times(1);
MediaSinkSearchResponseCallback sink_callback = base::Bind( MediaSinkSearchResponseCallback sink_callback = base::BindOnce(
&SinkResponseCallbackHandler::Invoke, base::Unretained(&sink_handler)); &SinkResponseCallbackHandler::Invoke, base::Unretained(&sink_handler));
router()->SearchSinks(kSinkId, kSource, search_input, domain, router()->SearchSinks(kSinkId, kSource, search_input, domain,
...@@ -1449,7 +1449,7 @@ class MediaRouterMojoExtensionTest : public ::testing::Test { ...@@ -1449,7 +1449,7 @@ class MediaRouterMojoExtensionTest : public ::testing::Test {
void RegisterMediaRouteProvider() { void RegisterMediaRouteProvider() {
media_router_proxy_->RegisterMediaRouteProvider( media_router_proxy_->RegisterMediaRouteProvider(
std::move(media_route_provider_proxy_), std::move(media_route_provider_proxy_),
base::Bind(&RegisterMediaRouteProviderHandler::Invoke, base::BindOnce(&RegisterMediaRouteProviderHandler::Invoke,
base::Unretained(&provider_handler_))); base::Unretained(&provider_handler_)));
} }
......
...@@ -77,7 +77,7 @@ void MediaRouterMojoTest::ConnectProviderManagerService() { ...@@ -77,7 +77,7 @@ void MediaRouterMojoTest::ConnectProviderManagerService() {
EXPECT_CALL(provide_handler_, InvokeInternal(kInstanceId, testing::_)); EXPECT_CALL(provide_handler_, InvokeInternal(kInstanceId, testing::_));
media_router_proxy_->RegisterMediaRouteProvider( media_router_proxy_->RegisterMediaRouteProvider(
std::move(mojo_media_router), std::move(mojo_media_router),
base::Bind(&RegisterMediaRouteProviderHandler::Invoke, base::BindOnce(&RegisterMediaRouteProviderHandler::Invoke,
base::Unretained(&provide_handler_))); base::Unretained(&provide_handler_)));
} }
......
...@@ -459,10 +459,10 @@ TEST_F(PresentationServiceDelegateImplTest, ListenForConnnectionStateChange) { ...@@ -459,10 +459,10 @@ TEST_F(PresentationServiceDelegateImplTest, ListenForConnnectionStateChange) {
delegate_impl_->ReconnectPresentation( delegate_impl_->ReconnectPresentation(
main_frame_process_id_, main_frame_routing_id_, presentation_urls_, main_frame_process_id_, main_frame_routing_id_, presentation_urls_,
kPresentationId, kPresentationId,
base::Bind(&MockCreatePresentationConnnectionCallbacks:: base::BindOnce(&MockCreatePresentationConnnectionCallbacks::
OnCreateConnectionSuccess, OnCreateConnectionSuccess,
base::Unretained(&mock_create_connection_callbacks)), base::Unretained(&mock_create_connection_callbacks)),
base::Bind( base::BindOnce(
&MockCreatePresentationConnnectionCallbacks::OnCreateConnectionError, &MockCreatePresentationConnnectionCallbacks::OnCreateConnectionError,
base::Unretained(&mock_create_connection_callbacks))); base::Unretained(&mock_create_connection_callbacks)));
...@@ -702,10 +702,10 @@ TEST_F(PresentationServiceDelegateImplTest, AutoJoinRequest) { ...@@ -702,10 +702,10 @@ TEST_F(PresentationServiceDelegateImplTest, AutoJoinRequest) {
delegate_impl_->ReconnectPresentation( delegate_impl_->ReconnectPresentation(
main_frame_process_id_, main_frame_routing_id_, presentation_urls_, main_frame_process_id_, main_frame_routing_id_, presentation_urls_,
kPresentationId, kPresentationId,
base::Bind(&MockCreatePresentationConnnectionCallbacks:: base::BindOnce(&MockCreatePresentationConnnectionCallbacks::
OnCreateConnectionSuccess, OnCreateConnectionSuccess,
base::Unretained(&mock_create_connection_callbacks)), base::Unretained(&mock_create_connection_callbacks)),
base::Bind( base::BindOnce(
&MockCreatePresentationConnnectionCallbacks::OnCreateConnectionError, &MockCreatePresentationConnnectionCallbacks::OnCreateConnectionError,
base::Unretained(&mock_create_connection_callbacks))); base::Unretained(&mock_create_connection_callbacks)));
...@@ -722,10 +722,10 @@ TEST_F(PresentationServiceDelegateImplTest, AutoJoinRequest) { ...@@ -722,10 +722,10 @@ TEST_F(PresentationServiceDelegateImplTest, AutoJoinRequest) {
delegate_impl_->ReconnectPresentation( delegate_impl_->ReconnectPresentation(
main_frame_process_id_, main_frame_routing_id_, presentation_urls_, main_frame_process_id_, main_frame_routing_id_, presentation_urls_,
kPresentationId, kPresentationId,
base::Bind(&MockCreatePresentationConnnectionCallbacks:: base::BindOnce(&MockCreatePresentationConnnectionCallbacks::
OnCreateConnectionSuccess, OnCreateConnectionSuccess,
base::Unretained(&mock_create_connection_callbacks)), base::Unretained(&mock_create_connection_callbacks)),
base::Bind( base::BindOnce(
&MockCreatePresentationConnnectionCallbacks::OnCreateConnectionError, &MockCreatePresentationConnnectionCallbacks::OnCreateConnectionError,
base::Unretained(&mock_create_connection_callbacks))); base::Unretained(&mock_create_connection_callbacks)));
} }
...@@ -765,10 +765,10 @@ TEST_F(PresentationServiceDelegateImplIncognitoTest, AutoJoinRequest) { ...@@ -765,10 +765,10 @@ TEST_F(PresentationServiceDelegateImplIncognitoTest, AutoJoinRequest) {
delegate_impl_->ReconnectPresentation( delegate_impl_->ReconnectPresentation(
main_frame_process_id_, main_frame_routing_id_, presentation_urls_, main_frame_process_id_, main_frame_routing_id_, presentation_urls_,
kPresentationId, kPresentationId,
base::Bind(&MockCreatePresentationConnnectionCallbacks:: base::BindOnce(&MockCreatePresentationConnnectionCallbacks::
OnCreateConnectionSuccess, OnCreateConnectionSuccess,
base::Unretained(&mock_create_connection_callbacks)), base::Unretained(&mock_create_connection_callbacks)),
base::Bind( base::BindOnce(
&MockCreatePresentationConnnectionCallbacks::OnCreateConnectionError, &MockCreatePresentationConnnectionCallbacks::OnCreateConnectionError,
base::Unretained(&mock_create_connection_callbacks))); base::Unretained(&mock_create_connection_callbacks)));
...@@ -785,10 +785,10 @@ TEST_F(PresentationServiceDelegateImplIncognitoTest, AutoJoinRequest) { ...@@ -785,10 +785,10 @@ TEST_F(PresentationServiceDelegateImplIncognitoTest, AutoJoinRequest) {
delegate_impl_->ReconnectPresentation( delegate_impl_->ReconnectPresentation(
main_frame_process_id_, main_frame_routing_id_, presentation_urls_, main_frame_process_id_, main_frame_routing_id_, presentation_urls_,
kPresentationId, kPresentationId,
base::Bind(&MockCreatePresentationConnnectionCallbacks:: base::BindOnce(&MockCreatePresentationConnnectionCallbacks::
OnCreateConnectionSuccess, OnCreateConnectionSuccess,
base::Unretained(&mock_create_connection_callbacks)), base::Unretained(&mock_create_connection_callbacks)),
base::Bind( base::BindOnce(
&MockCreatePresentationConnnectionCallbacks::OnCreateConnectionError, &MockCreatePresentationConnnectionCallbacks::OnCreateConnectionError,
base::Unretained(&mock_create_connection_callbacks))); base::Unretained(&mock_create_connection_callbacks)));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment