Commit 0215ccb5 authored by Hui Yingst's avatar Hui Yingst Committed by Commit Bot

Make setDocumentMetadata_() only take one parameter.

setDocumentMetadata_() has 3 parameters, which all comes from the same
structure MetadataMessageData. This CL makes setDocumentMetadata_() only
takes one MetadataMessageData type parameter instead.

Bug: 177188
Change-Id: I59c53252d91996ac13824c60ae1e7b276feb940e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386297
Commit-Queue: Hui Yingst <nigi@chromium.org>
Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804059}
parent d56da1b5
...@@ -708,9 +708,7 @@ export class PDFViewerElement extends PDFViewerBaseElement { ...@@ -708,9 +708,7 @@ export class PDFViewerElement extends PDFViewerBaseElement {
destinationData.zoom); destinationData.zoom);
return; return;
case 'metadata': case 'metadata':
const metadata = /** @type {!MetadataMessageData} */ (data); this.setDocumentMetadata_(/** @type {!MetadataMessageData} */ (data));
this.setDocumentMetadata_(
metadata.title, metadata.bookmarks, metadata.canSerializeDocument);
return; return;
case 'setIsEditing': case 'setIsEditing':
// Editing mode can only be entered once, and cannot be exited. // Editing mode can only be entered once, and cannot be exited.
...@@ -808,16 +806,14 @@ export class PDFViewerElement extends PDFViewerBaseElement { ...@@ -808,16 +806,14 @@ export class PDFViewerElement extends PDFViewerBaseElement {
/** /**
* Sets document metadata from the current controller. * Sets document metadata from the current controller.
* @param {string} title * @param {!MetadataMessageData} metadata
* @param {!Array<!Bookmark>} bookmarks
* @param {boolean} canSerializeDocument
* @private * @private
*/ */
setDocumentMetadata_(title, bookmarks, canSerializeDocument) { setDocumentMetadata_(metadata) {
this.title_ = title ? title : getFilenameFromURL(this.originalUrl); this.title_ = metadata.title || getFilenameFromURL(this.originalUrl);
document.title = this.title_; document.title = this.title_;
this.bookmarks_ = bookmarks; this.bookmarks_ = metadata.bookmarks;
this.canSerializeDocument_ = canSerializeDocument; this.canSerializeDocument_ = metadata.canSerializeDocument;
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment