Commit 024713b6 authored by Devlin Cronin's avatar Devlin Cronin Committed by Commit Bot

[Chrome Driver] Remove support for legacy background page key

The "background_page" key in an extension's manifest is restricted
to manifest v1 extensions, which we are removing support for. Remove
the check in ChromeDriver that looks for this.

Bug: 816677
Change-Id: I6835fecc261a4dbf8d2dafec47e3e32acddf107c
Reviewed-on: https://chromium-review.googlesource.com/988135Reviewed-by: default avatarJonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549251}
parent daf551db
...@@ -633,7 +633,6 @@ Status GetExtensionBackgroundPage(const base::DictionaryValue* manifest, ...@@ -633,7 +633,6 @@ Status GetExtensionBackgroundPage(const base::DictionaryValue* manifest,
if (manifest->Get("background.scripts", &unused_value)) if (manifest->Get("background.scripts", &unused_value))
bg_page_name = "_generated_background_page.html"; bg_page_name = "_generated_background_page.html";
manifest->GetString("background.page", &bg_page_name); manifest->GetString("background.page", &bg_page_name);
manifest->GetString("background_page", &bg_page_name);
if (bg_page_name.empty() || !persistent) if (bg_page_name.empty() || !persistent)
return Status(kOk); return Status(kOk);
GURL baseUrl("chrome-extension://" + id + "/"); GURL baseUrl("chrome-extension://" + id + "/");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment