cros: Update expanded search box according to spec

- Add drop shadow with elevation 12px using BubbleBorder;
- Change background of search box to always be white (#FFF);
- Change rounded corners to 20px;

Bug: 876091
Change-Id: Ic028bd5146a6618d03265929d12c82d74724e4c1
Reviewed-on: https://chromium-review.googlesource.com/c/1389120Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619825}

ash/app_list/views/contents_view.cc

@@ -569,7 +569,8 @@ void ContentsView::UpdateYPositionAndOpacity() {
               apps_container_view->GetSearchBoxExpectedBounds())));
 
   search_results_page_view()->SetBoundsRect(
-      apps_container_view->GetSearchBoxExpectedBounds());
+      search_results_page_view()->AddShadowBorderToBounds(
+          apps_container_view->GetSearchBoxExpectedBounds()));
 
   apps_container_view->UpdateYPositionAndOpacity();
 }

ash/app_list/views/search_box_view.cc

@@ -60,7 +60,6 @@ constexpr int kSearchBoxBorderWidth = 4;
 constexpr SkColor kSearchBoxBorderColor =
     SkColorSetARGB(0x3D, 0xFF, 0xFF, 0xFF);
 
-constexpr int kSearchBoxBorderCornerRadiusSearchResult = 4;
 constexpr int kAssistantIconSize = 24;
 constexpr int kCloseIconSize = 24;
 constexpr int kSearchBoxFocusBorderCornerRadius = 28;
@@ -304,7 +303,7 @@ int SearchBoxView::GetSearchBoxBorderCornerRadiusForState(
     ash::AppListState state) const {
   if (state == ash::AppListState::kStateSearchResults &&
       !app_list_view_->is_in_drag()) {
-    return kSearchBoxBorderCornerRadiusSearchResult;
+    return search_box::kSearchBoxBorderCornerRadiusSearchResult;
   }
   return search_box::kSearchBoxBorderCornerRadius;
 }

ash/app_list/views/search_result_page_view.cc

@@ -24,6 +24,7 @@
 #include "ui/gfx/geometry/insets.h"
 #include "ui/gfx/shadow_value.h"
 #include "ui/views/background.h"
+#include "ui/views/bubble/bubble_border.h"
 #include "ui/views/controls/scroll_view.h"
 #include "ui/views/controls/scrollbar/overlay_scroll_bar.h"
 #include "ui/views/controls/textfield/textfield.h"
@@ -48,6 +49,9 @@ constexpr int kSearchBoxHeight = 56;
 
 constexpr SkColor kSeparatorColor = SkColorSetA(gfx::kGoogleGrey900, 0x24);
 
+// The shadow elevation value for the shadow of the expanded search box.
+constexpr int kSearchBoxSearchResultShadowElevation = 12;
+
 // A container view that ensures the card background and the shadow are painted
 // in the correct order.
 class SearchCardView : public views::View {
@@ -82,8 +86,12 @@ class ZeroWidthVerticalScrollBar : public views::OverlayScrollBar {
 
 class SearchResultPageBackground : public views::Background {
  public:
-  SearchResultPageBackground(SkColor color, int corner_radius)
-      : color_(color), corner_radius_(corner_radius) {}
+  SearchResultPageBackground(SkColor color,
+                             int corner_radius,
+                             int shadow_inset_top)
+      : color_(color),
+        corner_radius_(corner_radius),
+        shadow_inset_top_(shadow_inset_top) {}
   ~SearchResultPageBackground() override {}
 
  private:
@@ -98,13 +106,14 @@ class SearchResultPageBackground : public views::Background {
     if (bounds.height() <= kSearchBoxHeight)
       return;
     // Draw a separator between SearchBoxView and SearchResultPageView.
-    bounds.set_y(kSearchBoxHeight);
+    bounds.set_y(kSearchBoxHeight + shadow_inset_top_);
     bounds.set_height(kSeparatorThickness);
     canvas->FillRect(bounds, kSeparatorColor);
   }
 
   const SkColor color_;
   const int corner_radius_;
+  const int shadow_inset_top_;
 
   DISALLOW_COPY_AND_ASSIGN(SearchResultPageBackground);
 };
@@ -146,11 +155,21 @@ SearchResultPageView::SearchResultPageView() : contents_view_(new views::View) {
   contents_view_->SetLayoutManager(std::make_unique<views::BoxLayout>(
       views::BoxLayout::kVertical, gfx::Insets(), 0));
 
+  // Create and set a shadow to be displayed as a border for this view.
+  auto shadow_border = std::make_unique<views::BubbleBorder>(
+      views::BubbleBorder::NONE, views::BubbleBorder::SMALL_SHADOW,
+      SK_ColorWHITE);
+  shadow_border->SetCornerRadius(
+      search_box::kSearchBoxBorderCornerRadiusSearchResult);
+  shadow_border->set_md_shadow_elevation(kSearchBoxSearchResultShadowElevation);
+  SetBorder(std::move(shadow_border));
+
   // Hides this view behind the search box by using the same color and
   // background border corner radius. All child views' background should be
   // set transparent so that the rounded corner is not overwritten.
   SetBackground(std::make_unique<SearchResultPageBackground>(
-      kCardBackgroundColor, search_box::kSearchBoxBorderCornerRadius));
+      kCardBackgroundColor, search_box::kSearchBoxBorderCornerRadius,
+      border()->GetInsets().top()));
   views::ScrollView* const scroller = new views::ScrollView;
   // Leaves a placeholder area for the search box and the separator below it.
   scroller->SetBorder(views::CreateEmptyBorder(
@@ -306,14 +325,20 @@ void SearchResultPageView::OnHidden() {
 
 gfx::Rect SearchResultPageView::GetPageBoundsForState(
     ash::AppListState state) const {
+  gfx::Rect onscreen_bounds;
+
   if (state != ash::AppListState::kStateSearchResults) {
     // Hides this view behind the search box by using the same bounds.
-    return AppListPage::contents_view()->GetSearchBoxBoundsForState(state);
-  }
-
-  gfx::Rect onscreen_bounds(AppListPage::GetSearchBoxBounds());
+    onscreen_bounds =
+        AppListPage::contents_view()->GetSearchBoxBoundsForState(state);
+  } else {
+    onscreen_bounds = AppListPage::GetSearchBoxBounds();
     onscreen_bounds.Offset((onscreen_bounds.width() - kWidth) / 2, 0);
     onscreen_bounds.set_size(GetPreferredSize());
+  }
+
+  onscreen_bounds = AddShadowBorderToBounds(onscreen_bounds);
+
   return onscreen_bounds;
 }
 
@@ -337,7 +362,8 @@ void SearchResultPageView::OnAnimationUpdated(double progress,
       gfx::Tween::LinearIntValueBetween(
           progress,
           search_box->GetSearchBoxBorderCornerRadiusForState(from_state),
-          search_box->GetSearchBoxBorderCornerRadiusForState(to_state))));
+          search_box->GetSearchBoxBorderCornerRadiusForState(to_state)),
+      border()->GetInsets().top()));
 
   gfx::Rect onscreen_bounds(
       GetPageBoundsForState(ash::AppListState::kStateSearchResults));
@@ -366,4 +392,11 @@ views::View* SearchResultPageView::GetLastFocusableView() {
       this, GetWidget(), true /* reverse */, false /* dont_loop */);
 }
 
+gfx::Rect SearchResultPageView::AddShadowBorderToBounds(
+    const gfx::Rect& bounds) const {
+  gfx::Rect new_bounds(bounds);
+  new_bounds.Inset(-border()->GetInsets());
+  return new_bounds;
+}
+
 }  // namespace app_list

ash/app_list/views/search_result_page_view.h

@@ -56,6 +56,10 @@ class APP_LIST_EXPORT SearchResultPageView
 
   SearchResultBaseView* first_result_view() const { return first_result_view_; }
 
+  // Offset/add the size of the shadow border to the bounds
+  // for proper sizing/placement with shadow included.
+  gfx::Rect AddShadowBorderToBounds(const gfx::Rect& bounds) const;
+
  private:
   // Separator between SearchResultContainerView.
   class HorizontalSeparator;

ash/public/cpp/app_list/app_list_constants.cc

@@ -42,7 +42,7 @@ const SkColor kFolderTitleHintTextColor = SkColorSetRGB(0xA0, 0xA0, 0xA0);
 const SkColor kFolderShadowColor = SkColorSetRGB(0xBF, 0xBF, 0xBF);
 const float kFolderBubbleOpacity = 0.12f;
 
-const SkColor kCardBackgroundColor = SkColorSetRGB(0xFA, 0xFA, 0xFC);
+const SkColor kCardBackgroundColor = SK_ColorWHITE;
 
 // Duration in milliseconds for page transition.
 const int kPageTransitionDurationInMs = 250;

ui/chromeos/search_box/search_box_constants.h

@@ -24,6 +24,9 @@ SEARCH_BOX_EXPORT constexpr SkColor kSearchBoxBackgroundDefault = SK_ColorWHITE;
 // The background border corner radius of the search box.
 SEARCH_BOX_EXPORT constexpr int kSearchBoxBorderCornerRadius = 24;
 
+// The background border corner radius of the expanded search box.
+SEARCH_BOX_EXPORT constexpr int kSearchBoxBorderCornerRadiusSearchResult = 20;
+
 // Preferred height of search box.
 SEARCH_BOX_EXPORT constexpr int kSearchBoxPreferredHeight = 48;