Commit 02d128d6 authored by Tomasz Wiszkowski's avatar Tomasz Wiszkowski Committed by Commit Bot

Record suggestion group expand/collapse events on Android.

This change introduces mechanism to record existing metrics
for omnibox suggestion groups expand/collapse on Android.

Bug: 1113476
Change-Id: Ie1ead60ed994eda5035972dc1feefab03b8b18a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339899
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795715}
parent 174dcfe7
......@@ -6,6 +6,7 @@ package org.chromium.chrome.browser.omnibox.suggestions.header;
import android.content.Context;
import org.chromium.base.metrics.RecordHistogram;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.omnibox.suggestions.DropdownItemProcessor;
import org.chromium.chrome.browser.omnibox.suggestions.OmniboxSuggestionUiType;
......@@ -62,7 +63,12 @@ public class HeaderProcessor implements DropdownItemProcessor {
@Override
public void onHeaderClicked() {
boolean newState = !model.get(HeaderViewProperties.IS_EXPANDED);
final boolean newState = !model.get(HeaderViewProperties.IS_EXPANDED);
RecordHistogram.recordSparseHistogram(newState
? "Omnibox.ToggleSuggestionGroupId.On"
: "Omnibox.ToggleSuggestionGroupId.Off",
groupId);
model.set(HeaderViewProperties.IS_EXPANDED, newState);
mSuggestionHost.setGroupVisibility(groupId, newState);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment