Commit 031db467 authored by Christopher Cameron's avatar Christopher Cameron Committed by Commit Bot

Remove unneeded virtual functions in ExtensionAppShimHandler

These get in the way of refactoring, and aren't used anyway.

TBR=raymes

Bug: 982024
Change-Id: Ifa87a5e7af30a8529bf531409b49307f499a64fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761714Reviewed-by: default avatarccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689124}
parent 2b31d3ae
...@@ -93,8 +93,8 @@ class ExtensionAppShimHandler : public AppShimHandler, ...@@ -93,8 +93,8 @@ class ExtensionAppShimHandler : public AppShimHandler,
~ExtensionAppShimHandler() override; ~ExtensionAppShimHandler() override;
// Get the host corresponding to a profile and app id, or null if there is // Get the host corresponding to a profile and app id, or null if there is
// none. Virtual for tests. // none.
virtual AppShimHost* FindHost(Profile* profile, const std::string& app_id); AppShimHost* FindHost(Profile* profile, const std::string& app_id);
// Return the host corresponding to |profile| and |app_id|, if one exists. // Return the host corresponding to |profile| and |app_id|, if one exists.
// If one does not exist, create one, and launch the app shim (so that the // If one does not exist, create one, and launch the app shim (so that the
...@@ -179,7 +179,6 @@ class ExtensionAppShimHandler : public AppShimHandler, ...@@ -179,7 +179,6 @@ class ExtensionAppShimHandler : public AppShimHandler,
// Exposed for testing. // Exposed for testing.
void set_delegate(Delegate* delegate); void set_delegate(Delegate* delegate);
HostMap& hosts() { return hosts_; }
content::NotificationRegistrar& registrar() { return registrar_; } content::NotificationRegistrar& registrar() { return registrar_; }
private: private:
......
...@@ -152,11 +152,6 @@ class TestingExtensionAppShimHandler : public ExtensionAppShimHandler { ...@@ -152,11 +152,6 @@ class TestingExtensionAppShimHandler : public ExtensionAppShimHandler {
ExtensionAppShimHandler::OnShimFocus(host, focus_type, files); ExtensionAppShimHandler::OnShimFocus(host, focus_type, files);
} }
AppShimHost* FindHost(Profile* profile, const std::string& app_id) {
HostMap::const_iterator it = hosts().find(make_pair(profile, app_id));
return it == hosts().end() ? NULL : it->second;
}
void SetAcceptablyCodeSigned(bool is_acceptable_code_signed) { void SetAcceptablyCodeSigned(bool is_acceptable_code_signed) {
is_acceptably_code_signed_ = is_acceptable_code_signed; is_acceptably_code_signed_ = is_acceptable_code_signed;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment