Commit 0352ec70 authored by Scott Graham's avatar Scott Graham Committed by Commit Bot

Fuchsia: Disable tests that rely on correctly set RTC

Temporarily disabling these tests as UTC time is being refactored/moved
out of the kernel, and is currently unreliable, causing these tests to
flake.

Bug: 1060357, fuchsia:47760
Change-Id: I3f3f46fc762a4b799b85aa4774839f7455b59b45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091216Reviewed-by: default avatarDavid Dorwin <ddorwin@chromium.org>
Reviewed-by: default avatarWez <wez@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748978}
parent 47bb7e34
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
#include "base/build_time.h" #include "base/build_time.h"
#include "base/generated_build_date.h" #include "base/generated_build_date.h"
#include "base/time/time.h" #include "base/time/time.h"
#include "build/build_config.h"
#include "testing/gtest/include/gtest/gtest.h" #include "testing/gtest/include/gtest/gtest.h"
...@@ -31,7 +32,14 @@ TEST(BuildTime, DateLooksValid) { ...@@ -31,7 +32,14 @@ TEST(BuildTime, DateLooksValid) {
#endif #endif
} }
TEST(BuildTime, InThePast) { #if defined(OS_FUCHSIA)
// TODO(https://crbug.com/1060357): Enable when RTC flake is fixed.
#define MAYBE_InThePast DISABLED_InThePast
#else
#define MAYBE_InThePast InThePast
#endif
TEST(BuildTime, MAYBE_InThePast) {
EXPECT_LT(base::GetBuildTime(), base::Time::Now()); EXPECT_LT(base::GetBuildTime(), base::Time::Now());
EXPECT_LT(base::GetBuildTime(), base::Time::NowFromSystemTime()); EXPECT_LT(base::GetBuildTime(), base::Time::NowFromSystemTime());
} }
...@@ -13,7 +13,14 @@ namespace base { ...@@ -13,7 +13,14 @@ namespace base {
namespace { namespace {
TEST(ScopedMockClockOverrideTest, Time) { #if defined(OS_FUCHSIA)
// TODO(https://crbug.com/1060357): Enable when RTC flake is fixed.
#define MAYBE_Time DISABLED_Time
#else
#define MAYBE_Time Time
#endif
TEST(ScopedMockClockOverrideTest, MAYBE_Time) {
// Choose a reference time that we know to be in the past but close to now. // Choose a reference time that we know to be in the past but close to now.
Time build_time = GetBuildTime(); Time build_time = GetBuildTime();
......
...@@ -911,7 +911,14 @@ class TimeOverride { ...@@ -911,7 +911,14 @@ class TimeOverride {
// static // static
Time TimeOverride::now_time_; Time TimeOverride::now_time_;
TEST_F(TimeTest, NowOverride) { #if defined(OS_FUCHSIA)
// TODO(https://crbug.com/1060357): Enable when RTC flake is fixed.
#define MAYBE_NowOverride DISABLED_NowOverride
#else
#define MAYBE_NowOverride NowOverride
#endif
TEST_F(TimeTest, MAYBE_NowOverride) {
TimeOverride::now_time_ = Time::UnixEpoch(); TimeOverride::now_time_ = Time::UnixEpoch();
// Choose a reference time that we know to be in the past but close to now. // Choose a reference time that we know to be in the past but close to now.
...@@ -965,6 +972,8 @@ TEST_F(TimeTest, NowOverride) { ...@@ -965,6 +972,8 @@ TEST_F(TimeTest, NowOverride) {
EXPECT_GT(Time::Max(), subtle::TimeNowFromSystemTimeIgnoringOverride()); EXPECT_GT(Time::Max(), subtle::TimeNowFromSystemTimeIgnoringOverride());
} }
#undef MAYBE_NowOverride
#if defined(OS_FUCHSIA) #if defined(OS_FUCHSIA)
TEST(ZxTimeTest, ToFromConversions) { TEST(ZxTimeTest, ToFromConversions) {
Time unix_epoch = Time::UnixEpoch(); Time unix_epoch = Time::UnixEpoch();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment