Commit 037f4ee9 authored by Roman Aleksandrov's avatar Roman Aleksandrov Committed by Commit Bot

PasswordChangeTest: Fix typo

Bug: None
Change-Id: I33f8caecc9123a377ded08c1ae5fba25d17e2955
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521191Reviewed-by: default avatarRoman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/master@{#825774}
parent b301dba7
...@@ -83,7 +83,7 @@ class PasswordChangeTestBase : public LoginManagerTest { ...@@ -83,7 +83,7 @@ class PasswordChangeTestBase : public LoginManagerTest {
// Sets up UserSessionManager to use stub authenticator that reports a // Sets up UserSessionManager to use stub authenticator that reports a
// password change, and attempts login. // password change, and attempts login.
// Password changed OOBE dialog is expected to show up after calling this. // Password changed OOBE dialog is expected to show up after calling this.
void SetUpStubAuthentcatorAndAttemptLogin(const std::string& old_password) { void SetUpStubAuthenticatorAndAttemptLogin(const std::string& old_password) {
EXPECT_TRUE(ash::LoginScreenTestApi::IsOobeDialogVisible()); EXPECT_TRUE(ash::LoginScreenTestApi::IsOobeDialogVisible());
UserContext user_context = GetTestUserContext(); UserContext user_context = GetTestUserContext();
...@@ -132,7 +132,7 @@ IN_PROC_BROWSER_TEST_F(PasswordChangeTest, MigrateOldCryptohome) { ...@@ -132,7 +132,7 @@ IN_PROC_BROWSER_TEST_F(PasswordChangeTest, MigrateOldCryptohome) {
OpenGaiaDialog(test_account_id_); OpenGaiaDialog(test_account_id_);
base::HistogramTester histogram_tester; base::HistogramTester histogram_tester;
SetUpStubAuthentcatorAndAttemptLogin("old user password"); SetUpStubAuthenticatorAndAttemptLogin("old user password");
WaitForPasswordChangeScreen(); WaitForPasswordChangeScreen();
histogram_tester.ExpectBucketCount("Login.PasswordChanged.ReauthReason", histogram_tester.ExpectBucketCount("Login.PasswordChanged.ReauthReason",
ReauthReason::OTHER, 1); ReauthReason::OTHER, 1);
...@@ -153,7 +153,7 @@ IN_PROC_BROWSER_TEST_F(PasswordChangeTest, MigrateOldCryptohome) { ...@@ -153,7 +153,7 @@ IN_PROC_BROWSER_TEST_F(PasswordChangeTest, MigrateOldCryptohome) {
IN_PROC_BROWSER_TEST_F(PasswordChangeTest, RetryOnWrongPassword) { IN_PROC_BROWSER_TEST_F(PasswordChangeTest, RetryOnWrongPassword) {
OpenGaiaDialog(test_account_id_); OpenGaiaDialog(test_account_id_);
SetUpStubAuthentcatorAndAttemptLogin("old user password"); SetUpStubAuthenticatorAndAttemptLogin("old user password");
WaitForPasswordChangeScreen(); WaitForPasswordChangeScreen();
test::OobeJS().CreateVisibilityWaiter(true, kPasswordStep)->Wait(); test::OobeJS().CreateVisibilityWaiter(true, kPasswordStep)->Wait();
...@@ -185,7 +185,7 @@ IN_PROC_BROWSER_TEST_F(PasswordChangeTest, RetryOnWrongPassword) { ...@@ -185,7 +185,7 @@ IN_PROC_BROWSER_TEST_F(PasswordChangeTest, RetryOnWrongPassword) {
IN_PROC_BROWSER_TEST_F(PasswordChangeTest, SkipDataRecovery) { IN_PROC_BROWSER_TEST_F(PasswordChangeTest, SkipDataRecovery) {
OpenGaiaDialog(test_account_id_); OpenGaiaDialog(test_account_id_);
SetUpStubAuthentcatorAndAttemptLogin("old user password"); SetUpStubAuthenticatorAndAttemptLogin("old user password");
WaitForPasswordChangeScreen(); WaitForPasswordChangeScreen();
test::OobeJS().CreateVisibilityWaiter(true, kPasswordStep)->Wait(); test::OobeJS().CreateVisibilityWaiter(true, kPasswordStep)->Wait();
...@@ -210,7 +210,7 @@ IN_PROC_BROWSER_TEST_F(PasswordChangeTest, SkipDataRecovery) { ...@@ -210,7 +210,7 @@ IN_PROC_BROWSER_TEST_F(PasswordChangeTest, SkipDataRecovery) {
IN_PROC_BROWSER_TEST_F(PasswordChangeTest, TryAgainAfterForgetLinkClick) { IN_PROC_BROWSER_TEST_F(PasswordChangeTest, TryAgainAfterForgetLinkClick) {
OpenGaiaDialog(test_account_id_); OpenGaiaDialog(test_account_id_);
SetUpStubAuthentcatorAndAttemptLogin("old user password"); SetUpStubAuthenticatorAndAttemptLogin("old user password");
WaitForPasswordChangeScreen(); WaitForPasswordChangeScreen();
test::OobeJS().CreateDisplayedWaiter(true, kPasswordStep)->Wait(); test::OobeJS().CreateDisplayedWaiter(true, kPasswordStep)->Wait();
...@@ -241,7 +241,7 @@ IN_PROC_BROWSER_TEST_F(PasswordChangeTest, TryAgainAfterForgetLinkClick) { ...@@ -241,7 +241,7 @@ IN_PROC_BROWSER_TEST_F(PasswordChangeTest, TryAgainAfterForgetLinkClick) {
IN_PROC_BROWSER_TEST_F(PasswordChangeTest, ClosePasswordChangedDialog) { IN_PROC_BROWSER_TEST_F(PasswordChangeTest, ClosePasswordChangedDialog) {
OpenGaiaDialog(test_account_id_); OpenGaiaDialog(test_account_id_);
SetUpStubAuthentcatorAndAttemptLogin("old user password"); SetUpStubAuthenticatorAndAttemptLogin("old user password");
WaitForPasswordChangeScreen(); WaitForPasswordChangeScreen();
test::OobeJS().CreateVisibilityWaiter(true, kPasswordStep)->Wait(); test::OobeJS().CreateVisibilityWaiter(true, kPasswordStep)->Wait();
...@@ -297,7 +297,7 @@ IN_PROC_BROWSER_TEST_F(PasswordChangeTokenCheck, LoginScreenPasswordChange) { ...@@ -297,7 +297,7 @@ IN_PROC_BROWSER_TEST_F(PasswordChangeTokenCheck, LoginScreenPasswordChange) {
OpenGaiaDialog(user_with_invalid_token_); OpenGaiaDialog(user_with_invalid_token_);
base::HistogramTester histogram_tester; base::HistogramTester histogram_tester;
SetUpStubAuthentcatorAndAttemptLogin("old user password"); SetUpStubAuthenticatorAndAttemptLogin("old user password");
WaitForPasswordChangeScreen(); WaitForPasswordChangeScreen();
histogram_tester.ExpectBucketCount("Login.PasswordChanged.ReauthReason", histogram_tester.ExpectBucketCount("Login.PasswordChanged.ReauthReason",
ReauthReason::INVALID_TOKEN_HANDLE, 1); ReauthReason::INVALID_TOKEN_HANDLE, 1);
...@@ -383,7 +383,7 @@ IN_PROC_BROWSER_TEST_F(PasswordChangeTokenCheck, Session) { ...@@ -383,7 +383,7 @@ IN_PROC_BROWSER_TEST_F(PasswordChangeTokenCheck, Session) {
OpenGaiaDialog(user_with_invalid_token_); OpenGaiaDialog(user_with_invalid_token_);
base::HistogramTester histogram_tester; base::HistogramTester histogram_tester;
SetUpStubAuthentcatorAndAttemptLogin("old user password"); SetUpStubAuthenticatorAndAttemptLogin("old user password");
WaitForPasswordChangeScreen(); WaitForPasswordChangeScreen();
histogram_tester.ExpectBucketCount("Login.PasswordChanged.ReauthReason", histogram_tester.ExpectBucketCount("Login.PasswordChanged.ReauthReason",
ReauthReason::INVALID_TOKEN_HANDLE, 1); ReauthReason::INVALID_TOKEN_HANDLE, 1);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment